* [RFC][PATCH] Input: ct82c710 - remove a redundant serio_register_port()
@ 2010-11-22 6:06 Axel Lin
2010-11-22 6:24 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-11-22 6:06 UTC (permalink / raw)
To: linux-kernel; +Cc: Dmitry Torokhov, linux-input, Vojtech Pavlik
We already call serio_register_port() in ct82c710_probe(),
thus remove a redundant serio_register_port() in ct82c710_init().
Looks like this bug is introduced by
916d83cfe5da1cda454d8b0ae233f06b58bd7f91
"Input: ct82c710 - convert to the new platform device interface"
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
I don't have this hardware handy, I appreciate if someone can test this patch.
Regards,
Axel
drivers/input/serio/ct82c710.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/input/serio/ct82c710.c b/drivers/input/serio/ct82c710.c
index 4a30846..0f8304a 100644
--- a/drivers/input/serio/ct82c710.c
+++ b/drivers/input/serio/ct82c710.c
@@ -237,8 +237,6 @@ static int __init ct82c710_init(void)
if (error)
goto err_free_device;
- serio_register_port(ct82c710_port);
-
printk(KERN_INFO "serio: C&T 82c710 mouse port at %#llx irq %d\n",
(unsigned long long)CT82C710_DATA, CT82C710_IRQ);
--
1.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC][PATCH] Input: ct82c710 - remove a redundant serio_register_port()
2010-11-22 6:06 [RFC][PATCH] Input: ct82c710 - remove a redundant serio_register_port() Axel Lin
@ 2010-11-22 6:24 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2010-11-22 6:24 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, linux-input, Vojtech Pavlik
On Mon, Nov 22, 2010 at 02:06:47PM +0800, Axel Lin wrote:
> We already call serio_register_port() in ct82c710_probe(),
> thus remove a redundant serio_register_port() in ct82c710_init().
>
> Looks like this bug is introduced by
> 916d83cfe5da1cda454d8b0ae233f06b58bd7f91
> "Input: ct82c710 - convert to the new platform device interface"
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> I don't have this hardware handy, I appreciate if someone can test this patch.
>
I doubt anyone has; maybe I should start pruning older drivers...
BTW, the fix is obviously correct so I'll apply it and your other two
patches as well. Thanks Axel.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-22 6:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-22 6:06 [RFC][PATCH] Input: ct82c710 - remove a redundant serio_register_port() Axel Lin
2010-11-22 6:24 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).