* [PATCH] Input: turbografx - fix reference counting
@ 2010-12-01 13:05 Namhyung Kim
2010-12-01 17:20 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2010-12-01 13:05 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel
The ref-count of parport gained from parport_find_number()
was not released in normal path.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
drivers/input/joystick/turbografx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
index d53b9e9..27b6a3c 100644
--- a/drivers/input/joystick/turbografx.c
+++ b/drivers/input/joystick/turbografx.c
@@ -245,6 +245,7 @@ static struct tgfx __init *tgfx_probe(int parport, int *n_buttons, int n_devs)
goto err_free_tgfx;
}
+ parport_put_port(pp);
return tgfx;
err_free_dev:
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: turbografx - fix reference counting
2010-12-01 13:05 [PATCH] Input: turbografx - fix reference counting Namhyung Kim
@ 2010-12-01 17:20 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2010-12-01 17:20 UTC (permalink / raw)
To: Namhyung Kim; +Cc: linux-input, linux-kernel
On Wed, Dec 01, 2010 at 10:05:01PM +0900, Namhyung Kim wrote:
> The ref-count of parport gained from parport_find_number()
> was not released in normal path.
>
Applied, thanks.
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
> drivers/input/joystick/turbografx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
> index d53b9e9..27b6a3c 100644
> --- a/drivers/input/joystick/turbografx.c
> +++ b/drivers/input/joystick/turbografx.c
> @@ -245,6 +245,7 @@ static struct tgfx __init *tgfx_probe(int parport, int *n_buttons, int n_devs)
> goto err_free_tgfx;
> }
>
> + parport_put_port(pp);
> return tgfx;
>
> err_free_dev:
> --
> 1.7.0.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-01 17:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-01 13:05 [PATCH] Input: turbografx - fix reference counting Namhyung Kim
2010-12-01 17:20 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).