From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: [PATCH] msm: trout: add keypad support Date: Mon, 13 Dec 2010 10:41:32 -0800 Message-ID: <1292265692.2700.0.camel@c-dwalke-linux.qualcomm.com> References: <1291854285-29566-1-git-send-email-dwalker@codeaurora.org> <4D00800E.7050004@codeaurora.org> <1291916733.18827.1.camel@c-dwalke-linux.qualcomm.com> <1291932216.18827.16.camel@c-dwalke-linux.qualcomm.com> <4D01D776.6000309@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:47166 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758683Ab0LMSlt (ORCPT ); Mon, 13 Dec 2010 13:41:49 -0500 In-Reply-To: <4D01D776.6000309@codeaurora.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Trilok Soni Cc: Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Fri, 2010-12-10 at 13:02 +0530, Trilok Soni wrote: > Hi Daniel, >=20 > On 12/10/2010 3:33 AM, Daniel Walker wrote: > > On Thu, 2010-12-09 at 14:01 -0800, Arve Hj=C3=B8nnev=C3=A5g wrote: > >> On Thu, Dec 9, 2010 at 9:45 AM, Daniel Walker wrote: > >>> On Thu, 2010-12-09 at 12:36 +0530, Trilok Soni wrote: > >>> > >>>>> +static char *keycaps =3D "--qwerty"; > >>>>> +#undef MODULE_PARAM_PREFIX > >>>>> +#define MODULE_PARAM_PREFIX "board_trout." > >>>>> +module_param_named(keycaps, keycaps, charp, 0); > >>>> > >>>> I would like to know what is the use of this param? > >>> > >>> No idea .. It was part of Google's implementation .. > >>> > >> > >> You removed the code that uses it. If you look at the original fil= e > >> you can see how it is used: > >> http://android.git.kernel.org/?p=3Dkernel/msm.git;a=3Dblob;f=3Darc= h/arm/mach-msm/board-trout-keypad.c;hb=3Drefs/heads/android-msm-2.6.35 > >> It is set by the bootloader according to the hardware version. > >> > >> You can also see that the "/* userspace needs to know about these > >> changes as well */" comments refer to the code that changes the na= me > >> of the input device. > >> > >> I don't think this change will work correctly with our existing > >> user-space code though since you are now reporting the power-key, > >> camera-key and slide-switch from a separate input device. > >=20 > > Yeah, I did remove those parts.. I'm not sure where to put that stu= ff in > > this new implementation. I can try to find an appropriate place , u= nless > > you have some suggestions ? >=20 > To support this, we need to override the input device .name and submi= t the patches > for matrix keypad and gpio keys and let the name come through platfor= m data.=20 >=20 > You can refer how I am doing in PM8058 keypad driver patch. Not sure what your talking about .. I'm not making a new driver. I'm just using the matrix keypad driver. Daniel --=20 Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora For= um. -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html