* [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop
@ 2010-12-27 15:27 David Sterba
2010-12-27 15:33 ` David Sterba
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David Sterba @ 2010-12-27 15:27 UTC (permalink / raw)
To: linux-input; +Cc: linux-kernel, David Sterba, Bruno Prémont, Jiri Kosina
CC: Bruno Prémont <bonbons@linux-vserver.org>
CC: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: David Sterba <dsterba@suse.cz>
---
drivers/hid/hid-picolcd.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
index bc2e077..0aff3cd 100644
--- a/drivers/hid/hid-picolcd.c
+++ b/drivers/hid/hid-picolcd.c
@@ -1544,7 +1544,7 @@ static ssize_t picolcd_debug_eeprom_read(struct file *f, char __user *u,
/* prepare buffer with info about what we want to read (addr & len) */
raw_data[0] = *off & 0xff;
- raw_data[1] = (*off >> 8) && 0xff;
+ raw_data[1] = (*off >> 8) & 0xff;
raw_data[2] = s < 20 ? s : 20;
if (*off + raw_data[2] > 0xff)
raw_data[2] = 0x100 - *off;
@@ -1583,7 +1583,7 @@ static ssize_t picolcd_debug_eeprom_write(struct file *f, const char __user *u,
memset(raw_data, 0, sizeof(raw_data));
raw_data[0] = *off & 0xff;
- raw_data[1] = (*off >> 8) && 0xff;
+ raw_data[1] = (*off >> 8) & 0xff;
raw_data[2] = s < 20 ? s : 20;
if (*off + raw_data[2] > 0xff)
raw_data[2] = 0x100 - *off;
--
1.7.3.4.578.g6068a
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop
2010-12-27 15:27 [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop David Sterba
@ 2010-12-27 15:33 ` David Sterba
2010-12-27 15:39 ` Jiri Kosina
2010-12-27 21:47 ` Bruno Prémont
2 siblings, 0 replies; 4+ messages in thread
From: David Sterba @ 2010-12-27 15:33 UTC (permalink / raw)
To: linux-input; +Cc: linux-kernel, Bruno Prémont, Jiri Kosina
On Monday 27 December 2010 16:27:43 David Sterba wrote:
> Re: [PATCH 1/3]
^^^
sorry, I forgot to give --no-numbered to format-patch, this is just one patch,
dave
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop
2010-12-27 15:27 [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop David Sterba
2010-12-27 15:33 ` David Sterba
@ 2010-12-27 15:39 ` Jiri Kosina
2010-12-27 21:47 ` Bruno Prémont
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2010-12-27 15:39 UTC (permalink / raw)
To: David Sterba; +Cc: linux-input, linux-kernel, Bruno Prémont
On Mon, 27 Dec 2010, David Sterba wrote:
> CC: Bruno Prémont <bonbons@linux-vserver.org>
> CC: Jiri Kosina <jkosina@suse.cz>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
> drivers/hid/hid-picolcd.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
> index bc2e077..0aff3cd 100644
> --- a/drivers/hid/hid-picolcd.c
> +++ b/drivers/hid/hid-picolcd.c
> @@ -1544,7 +1544,7 @@ static ssize_t picolcd_debug_eeprom_read(struct file *f, char __user *u,
>
> /* prepare buffer with info about what we want to read (addr & len) */
> raw_data[0] = *off & 0xff;
> - raw_data[1] = (*off >> 8) && 0xff;
> + raw_data[1] = (*off >> 8) & 0xff;
> raw_data[2] = s < 20 ? s : 20;
> if (*off + raw_data[2] > 0xff)
> raw_data[2] = 0x100 - *off;
> @@ -1583,7 +1583,7 @@ static ssize_t picolcd_debug_eeprom_write(struct file *f, const char __user *u,
>
> memset(raw_data, 0, sizeof(raw_data));
> raw_data[0] = *off & 0xff;
> - raw_data[1] = (*off >> 8) && 0xff;
> + raw_data[1] = (*off >> 8) & 0xff;
> raw_data[2] = s < 20 ? s : 20;
> if (*off + raw_data[2] > 0xff)
> raw_data[2] = 0x100 - *off;
Applied, thank you.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop
2010-12-27 15:27 [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop David Sterba
2010-12-27 15:33 ` David Sterba
2010-12-27 15:39 ` Jiri Kosina
@ 2010-12-27 21:47 ` Bruno Prémont
2 siblings, 0 replies; 4+ messages in thread
From: Bruno Prémont @ 2010-12-27 21:47 UTC (permalink / raw)
To: David Sterba; +Cc: linux-input, linux-kernel, Jiri Kosina
Thanks for spotting,
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
On Mon, 27 December 2010 David Sterba <dsterba@suse.cz> wrote:
> CC: Bruno Prémont <bonbons@linux-vserver.org>
> CC: Jiri Kosina <jkosina@suse.cz>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
> drivers/hid/hid-picolcd.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
> index bc2e077..0aff3cd 100644
> --- a/drivers/hid/hid-picolcd.c
> +++ b/drivers/hid/hid-picolcd.c
> @@ -1544,7 +1544,7 @@ static ssize_t picolcd_debug_eeprom_read(struct file *f, char __user *u,
>
> /* prepare buffer with info about what we want to read (addr & len) */
> raw_data[0] = *off & 0xff;
> - raw_data[1] = (*off >> 8) && 0xff;
> + raw_data[1] = (*off >> 8) & 0xff;
> raw_data[2] = s < 20 ? s : 20;
> if (*off + raw_data[2] > 0xff)
> raw_data[2] = 0x100 - *off;
> @@ -1583,7 +1583,7 @@ static ssize_t picolcd_debug_eeprom_write(struct file *f, const char __user *u,
>
> memset(raw_data, 0, sizeof(raw_data));
> raw_data[0] = *off & 0xff;
> - raw_data[1] = (*off >> 8) && 0xff;
> + raw_data[1] = (*off >> 8) & 0xff;
> raw_data[2] = s < 20 ? s : 20;
> if (*off + raw_data[2] > 0xff)
> raw_data[2] = 0x100 - *off;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-27 21:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-27 15:27 [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop David Sterba
2010-12-27 15:33 ` David Sterba
2010-12-27 15:39 ` Jiri Kosina
2010-12-27 21:47 ` Bruno Prémont
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).