From: Andy Whitcroft <apw@canonical.com>
To: Dmitry Torokhov <dtor@mail.ru>
Cc: Andy Whitcroft <apw@canonical.com>,
linux-input@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] Input: sysrq -- ensure sysrq_enabled and __sysrq_enabled are consistent
Date: Sat, 15 Jan 2011 20:23:57 +0000 [thread overview]
Message-ID: <1295123037-2649-2-git-send-email-apw@canonical.com> (raw)
In-Reply-To: <1295123037-2649-1-git-send-email-apw@canonical.com>
Currently sysrq_enabled and __sysrq_enabled are initialised separatly
and inconsitantly, leading to sysrq being actually enabled by reported
as not enabled in sysfs. The first change to the sysfs configurable
synchronises these two:
static int __read_mostly sysrq_enabled = 1;
static int __sysrq_enabled;
Add a new configuration value which sets the default for these preventing
them becoming out of sync again. Default this to 1 to mirror previous
behaviour.
Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
drivers/tty/sysrq.c | 2 +-
kernel/sysctl.c | 3 ++-
lib/Kconfig.debug | 9 +++++++++
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index c556ed9..ba8cf87 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -46,7 +46,7 @@
#include <asm/irq_regs.h>
/* Whether we react on sysrq keys or just ignore them */
-static int __read_mostly sysrq_enabled = 1;
+static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT;
static bool __read_mostly sysrq_always_enabled;
static bool sysrq_on(void)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index bc86bb3..85fd935 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -170,7 +170,8 @@ static int proc_taint(struct ctl_table *table, int write,
#endif
#ifdef CONFIG_MAGIC_SYSRQ
-static int __sysrq_enabled; /* Note: sysrq code ises it's own private copy */
+/* Note: sysrq code uses it's own private copy */
+static int __sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT;
static int sysrq_sysctl_handler(ctl_table *table, int write,
void __user *buffer, size_t *lenp,
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 2d05adb..459105e 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -50,6 +50,15 @@ config MAGIC_SYSRQ
keys are documented in <file:Documentation/sysrq.txt>. Don't say Y
unless you really know what this hack does.
+config MAGIC_SYSRQ_DEFAULT
+ int "Magic SysRq key default"
+ default 1
+ range 0 1
+ help
+ Set the default value for the sysrq sysfs control to this value.
+ Setting this to 1 will enable sysrq on boot, to 0 will disable
+ sysrq on boot.
+
config STRIP_ASM_SYMS
bool "Strip assembler-generated symbols during link"
default n
--
1.7.2.3
next prev parent reply other threads:[~2011-01-15 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 20:23 [PATCH 0/1] sysrq is half-enabled by default Andy Whitcroft
2011-01-15 20:23 ` Andy Whitcroft [this message]
2011-01-15 21:54 ` Dmitry Torokhov
2011-01-18 9:38 ` Andy Whitcroft
-- strict thread matches above, loose matches on Subject: below --
2011-01-24 14:06 [PATCH 0/1] sysrq is half-enabled by default V2 Andy Whitcroft
2011-01-24 14:06 ` [PATCH 1/1] Input: sysrq -- ensure sysrq_enabled and __sysrq_enabled are consistent Andy Whitcroft
2011-01-24 16:03 ` Randy Dunlap
2011-01-24 17:04 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295123037-2649-2-git-send-email-apw@canonical.com \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dtor@mail.ru \
--cc=gregkh@suse.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).