From: Sourav Poddar <sourav.poddar@ti.com>
To: dmitry.torokhov@gmail.com
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
charu@ti.com, gadiyar@ti.com, linux-input@vger.kernel.org,
balbi@ti.com, Sourav Poddar <sourav.poddar@ti.com>
Subject: [PATCHv2 2/2] Input: ads7846 - configure pendown gpio as input
Date: Thu, 3 Feb 2011 15:18:50 +0530 [thread overview]
Message-ID: <1296726530-32199-1-git-send-email-sourav.poddar@ti.com> (raw)
The ads7846 driver requests a gpio to detect pendown events,
but does not configure its direction. Configure this gpio
as an input after requesting it.
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
changes between v2 and v1: Added return error support in v2.
drivers/input/touchscreen/ads7846.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 036f245..f30768b 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -962,6 +962,13 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784
return err;
}
+ err = gpio_direction_input(pdata->gpio_pendown);
+ if (err) {
+ dev_err(&spi->dev, "failed to configure pendown GPIO input direction %d\n",
+ pdata->gpio_pendown);
+ return err;
+ }
+
ts->gpio_pendown = pdata->gpio_pendown;
return 0;
--
1.7.0.4
next reply other threads:[~2011-02-03 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 9:48 Sourav Poddar [this message]
2011-02-03 9:58 ` [PATCHv2 2/2] Input: ads7846 - configure pendown gpio as input Felipe Balbi
2011-02-03 10:04 ` Varadarajan, Charulatha
2011-02-03 13:01 ` Poddar, Sourav
2011-02-03 10:10 ` Wolfram Sang
2011-02-03 10:22 ` Felipe Balbi
2011-02-03 11:42 ` Poddar, Sourav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296726530-32199-1-git-send-email-sourav.poddar@ti.com \
--to=sourav.poddar@ti.com \
--cc=balbi@ti.com \
--cc=charu@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gadiyar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).