* [RFC] Port of hid-egalax to the unified hid-multitouch driver
@ 2011-03-06 13:24 Richard Nauber
2011-03-07 10:04 ` Benjamin Tissoires
0 siblings, 1 reply; 6+ messages in thread
From: Richard Nauber @ 2011-03-06 13:24 UTC (permalink / raw)
To: linux-input; +Cc: Jiri Kosina, Henrik Rydberg
Hi everyone,
I wrote this little patch that merges hid-egalax into hid-multitouch.
(It applies to 2.6.38-rc7, but I can rebase it as you please...) The
latter driver has to gain a new quirk type (MT_QUIRK_EGALAX) for fixing
the reported ranges (X,Y and Z) and work around the corrupt packet
length (td->last_field_index).
With these changes it works like a charm for my Samsung MB30
touchscreen and by the way fixes the broken suspend/resume behavior.
So I'd like you to test it for other egalax devices and give me your
feedback on this patch.
Thanks and Greetings,
Richard
[input-hid] Add hid-egalax driver to the unified hid-multitouch
framework.
drivers/hid/Kconfig | 9 +-
drivers/hid/Makefile | 1 -
drivers/hid/hid-egalax.c | 279
------------------------------------------
drivers/hid/hid-multitouch.c | 48 +++++++-
4 files changed, 47 insertions(+), 290 deletions(-)
delete mode 100644 drivers/hid/hid-egalax.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] Port of hid-egalax to the unified hid-multitouch driver
2011-03-06 13:24 [RFC] Port of hid-egalax to the unified hid-multitouch driver Richard Nauber
@ 2011-03-07 10:04 ` Benjamin Tissoires
2011-03-08 13:14 ` Jiri Kosina
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Tissoires @ 2011-03-07 10:04 UTC (permalink / raw)
To: Richard Nauber; +Cc: linux-input, Jiri Kosina, Henrik Rydberg
Hi Richard,
Thank you very much for this work. This reminds me that we have to
switch the other drivers to hid-multitouch too.
Actually, I was not in favor of porting this driver into
hid-multitouch. eGalax has two differents protocols: one for resistive
technology (which is compatible with hid-multitouch in its current
form), and one for capacitive technology (which requires the "corrupt
packet length" quirk).
Apparently, according to the kernel logs the Samsung MB30 is a
resistive technology (correct me if I'm wrong). This means that we
also need testings for the capacitive one.
I'll let the community decide whether we should include this in
hid-multitouch. Henrik, Jiri, any idea?
Now let's go for the review!
Cheers,
Benjamin
On Sun, Mar 6, 2011 at 14:24, Richard Nauber
<richard.nauber@googlemail.com> wrote:
> Hi everyone,
> I wrote this little patch that merges hid-egalax into hid-multitouch.
> (It applies to 2.6.38-rc7, but I can rebase it as you please...) The
> latter driver has to gain a new quirk type (MT_QUIRK_EGALAX) for fixing
> the reported ranges (X,Y and Z) and work around the corrupt packet
> length (td->last_field_index).
> With these changes it works like a charm for my Samsung MB30
> touchscreen and by the way fixes the broken suspend/resume behavior.
>
> So I'd like you to test it for other egalax devices and give me your
> feedback on this patch.
>
> Thanks and Greetings,
> Richard
>
> [input-hid] Add hid-egalax driver to the unified hid-multitouch
> framework.
>
> drivers/hid/Kconfig | 9 +-
> drivers/hid/Makefile | 1 -
> drivers/hid/hid-egalax.c | 279
> ------------------------------------------
> drivers/hid/hid-multitouch.c | 48 +++++++-
> 4 files changed, 47 insertions(+), 290 deletions(-)
> delete mode 100644 drivers/hid/hid-egalax.c
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] Port of hid-egalax to the unified hid-multitouch driver
2011-03-07 10:04 ` Benjamin Tissoires
@ 2011-03-08 13:14 ` Jiri Kosina
2011-03-08 13:29 ` Henrik Rydberg
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2011-03-08 13:14 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Richard Nauber, linux-input, Henrik Rydberg
On Mon, 7 Mar 2011, Benjamin Tissoires wrote:
> Thank you very much for this work.
Indeed, thanks a lot Richard.
> This reminds me that we have to switch the other drivers to
> hid-multitouch too.
That would be nice. I don't see this really being done for the upcoming
merge window, right Benjamin?
> Actually, I was not in favor of porting this driver into hid-multitouch.
> eGalax has two differents protocols: one for resistive technology (which
> is compatible with hid-multitouch in its current form), and one for
> capacitive technology (which requires the "corrupt packet length"
> quirk).
>
> Apparently, according to the kernel logs the Samsung MB30 is a resistive
> technology (correct me if I'm wrong). This means that we also need
> testings for the capacitive one.
>
> I'll let the community decide whether we should include this in
> hid-multitouch. Henrik, Jiri, any idea?
Either directly hid-multitouch, or hid-multitouch-capacitive sub-module
should be fine.
Thanks for the efforts,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] Port of hid-egalax to the unified hid-multitouch driver
2011-03-08 13:14 ` Jiri Kosina
@ 2011-03-08 13:29 ` Henrik Rydberg
2011-03-08 15:12 ` Benjamin Tissoires
0 siblings, 1 reply; 6+ messages in thread
From: Henrik Rydberg @ 2011-03-08 13:29 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, Richard Nauber, linux-input
> > This reminds me that we have to switch the other drivers to
> > hid-multitouch too.
>
> That would be nice. I don't see this really being done for the upcoming
> merge window, right Benjamin?
There has been no activity in that direction here either...
> > Actually, I was not in favor of porting this driver into hid-multitouch.
> > eGalax has two differents protocols: one for resistive technology (which
> > is compatible with hid-multitouch in its current form), and one for
> > capacitive technology (which requires the "corrupt packet length"
> > quirk).
> >
> > Apparently, according to the kernel logs the Samsung MB30 is a resistive
> > technology (correct me if I'm wrong). This means that we also need
> > testings for the capacitive one.
> >
> > I'll let the community decide whether we should include this in
> > hid-multitouch. Henrik, Jiri, any idea?
>
> Either directly hid-multitouch, or hid-multitouch-capacitive sub-module
> should be fine.
Maybe it is obvious already, but I think the patch is great. There is
really no reason to split the driver - in particular given that the
manufacturer has ensured similar behavior from both types.
Thanks,
Henrik
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] Port of hid-egalax to the unified hid-multitouch driver
2011-03-08 13:29 ` Henrik Rydberg
@ 2011-03-08 15:12 ` Benjamin Tissoires
2011-03-08 15:21 ` Jiri Kosina
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Tissoires @ 2011-03-08 15:12 UTC (permalink / raw)
To: Henrik Rydberg; +Cc: Jiri Kosina, Richard Nauber, linux-input
On Tue, Mar 8, 2011 at 14:29, Henrik Rydberg <rydberg@euromail.se> wrote:
>> > This reminds me that we have to switch the other drivers to
>> > hid-multitouch too.
>>
>> That would be nice. I don't see this really being done for the upcoming
>> merge window, right Benjamin?
>
> There has been no activity in that direction here either...
I've got Stantum, Cando and 3m that can be merged right now. I mean
that they have been tested and do not have regressions (crossing
fingers).
This let Quanta and Mosart. I'm sure they worked some weeks ago, but
I'm not sure (tested the last few days) ATM.
If you want, I can send the three that goes well, and for the other,
we'll see for 2.6.40.
I have the auto-detection of contact counts that could go for 2.6.39 as well.
Cheers,
Benjamin
>
>> > Actually, I was not in favor of porting this driver into hid-multitouch.
>> > eGalax has two differents protocols: one for resistive technology (which
>> > is compatible with hid-multitouch in its current form), and one for
>> > capacitive technology (which requires the "corrupt packet length"
>> > quirk).
>> >
>> > Apparently, according to the kernel logs the Samsung MB30 is a resistive
>> > technology (correct me if I'm wrong). This means that we also need
>> > testings for the capacitive one.
>> >
>> > I'll let the community decide whether we should include this in
>> > hid-multitouch. Henrik, Jiri, any idea?
>>
>> Either directly hid-multitouch, or hid-multitouch-capacitive sub-module
>> should be fine.
>
> Maybe it is obvious already, but I think the patch is great. There is
> really no reason to split the driver - in particular given that the
> manufacturer has ensured similar behavior from both types.
>
> Thanks,
> Henrik
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] Port of hid-egalax to the unified hid-multitouch driver
2011-03-08 15:12 ` Benjamin Tissoires
@ 2011-03-08 15:21 ` Jiri Kosina
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2011-03-08 15:21 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Henrik Rydberg, Richard Nauber, linux-input
On Tue, 8 Mar 2011, Benjamin Tissoires wrote:
> >> That would be nice. I don't see this really being done for the upcoming
> >> merge window, right Benjamin?
> >
> > There has been no activity in that direction here either...
>
> I've got Stantum, Cando and 3m that can be merged right now. I mean
> that they have been tested and do not have regressions (crossing
> fingers).
> This let Quanta and Mosart. I'm sure they worked some weeks ago, but
> I'm not sure (tested the last few days) ATM.
Perfect, thanks a lot for your work on this.
> If you want, I can send the three that goes well, and for the other,
> we'll see for 2.6.40.
> I have the auto-detection of contact counts that could go for 2.6.39 as
> well.
Yes, please send around whatever you have and consider ready for merge, so
that it could be reviewed and merged for the upcoming merge window still.
Thanks again,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-08 15:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-06 13:24 [RFC] Port of hid-egalax to the unified hid-multitouch driver Richard Nauber
2011-03-07 10:04 ` Benjamin Tissoires
2011-03-08 13:14 ` Jiri Kosina
2011-03-08 13:29 ` Henrik Rydberg
2011-03-08 15:12 ` Benjamin Tissoires
2011-03-08 15:21 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).