Re: [PATCH v2 4/4] iio: humidity: drop hid_sensor_remove_trigger() using devm API

[Sanjay Chitroda <sanjayembeddedse@gmail.com>]

On 30 April 2026 1:03:56 am IST, Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>On Wed, Apr 29, 2026 at 11:29:18PM +0530, Sanjay Chitroda wrote:
>
>> Use devm_hid_sensor_setup_trigger() to automatically release resource
>> during fail, unbind or removal of driver using devres framework.
>> 
>> This simplify the setup, remove goto, avoid manual resource cleanup in
>> teardown path.
>
>...
>
>> -	ret = hid_sensor_setup_trigger(indio_dev, name,
>> -				&humid_st->common_attributes);
>> +	ret = devm_hid_sensor_setup_trigger(&indio_dev->dev, indio_dev, name,
>> +					    &humid_st->common_attributes);
>
>I believe the first parameter is utterly wrong here.
>Or other way around, same issue but in the previous patch.
>
Thank you Andy for the review comment.

It looks in same humidity probe of hid sensor with devm API two device pointer are used &pdev->dev and &indio_dev->dev; ideally all devm should have same parent device for devres resource framework and over here preferable and consistent device should be &pdev->dev;

I would first update existing devm_* API to have consistent device and on top of that will use same device in devm conversation.

While for gyro change device is consistent as &pdev->dev across all devm API.

Thanks,
Sanjay Chitroda 


>>  	if (ret)
>>  		return ret;
>