From: Bastien Nocera <hadess@hadess.net>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] input: goodix - support Goodix gt5688
Date: Tue, 29 Jan 2019 11:30:53 +0100 [thread overview]
Message-ID: <12e21befacf68861ddf34020838ff7a6e6e078ad.camel@hadess.net> (raw)
In-Reply-To: <20190129091651.GA8497@bogon.m.sigxcpu.org>
On Tue, 2019-01-29 at 10:16 +0100, Guido Günther wrote:
> Hi,
> On Mon, Jan 28, 2019 at 07:24:33PM +0100, Bastien Nocera wrote:
> > On Mon, 2019-01-28 at 18:03 +0100, Guido Günther wrote:
> > > From what I've seen in vendor trees it's fine to treat this as
> > > gt1x¹.
> > >
> > > [1]:
> > > https://github.com/TadiT7/android_kernel_mtk-4.4/tree/master/drivers/input/touchscreen/mediatek/GT5688
> >
> > Can you please point to the exact line of code that makes you say
> > that?
> > I'm not saying it's not compatible, but it's not the same driver
> > that
> > the current goodix.c was based on, or even goodix.c.
> >
> > Can you please elaborate?
>
> I basically looked at the registers uses for the config update:
>
> https://github.com/TadiT7/android_kernel_mtk-4.4/blob/master/drivers/input/touchscreen/mediatek/GT5688/include/gt1x_tpd_common.h#L152
> https://github.com/TadiT7/android_kernel_mtk-4.4/blob/master/drivers/input/touchscreen/mediatek/GT5688/gt1x_generic.c#L430
I'm not sure that's good enough to say that the touchscreen models are
compatible.
> That and the fact that the driver is doing it's job well made me
> believe
> that's good for base support.
If you've tested it, that's better. Can you please add a reference to
the device that you've tested this on in the commit message?
> Things like hotknot, gesture wakeup and
> proximity sensor will need additional work.
>
> > Finding that data in the specs would also be fine:
> > https://github.com/hadess/gt9xx/tree/master/specifications
>
> https://github.com/hadess/gt9xx/pull/3
Merged that, thanks
Cheers
next prev parent reply other threads:[~2019-01-29 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 17:03 [PATCH] input: goodix - support Goodix gt5688 Guido Günther
2019-01-28 18:24 ` Bastien Nocera
2019-01-29 9:16 ` Guido Günther
2019-01-29 10:30 ` Bastien Nocera [this message]
2019-01-29 11:11 ` [PATCH v2] " Guido Günther
2019-01-29 11:35 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12e21befacf68861ddf34020838ff7a6e6e078ad.camel@hadess.net \
--to=hadess@hadess.net \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).