linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: roccat: Corrected mode of sysfs attr 'sensor' from koneplus driver
@ 2011-03-14 20:43 Stefan Achatz
  2011-03-15 14:41 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Achatz @ 2011-03-14 20:43 UTC (permalink / raw)
  To: Jiri Kosina, linux-input, linux-kernel

Mode of sysfs attribute 'sensor' was wrongly set to writeonly.
Corrected this to readwrite.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
---
 drivers/hid/hid-roccat-koneplus.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/hid/hid-roccat-koneplus.c b/drivers/hid/hid-roccat-koneplus.c
index a8e2117..33eec74 100644
--- a/drivers/hid/hid-roccat-koneplus.c
+++ b/drivers/hid/hid-roccat-koneplus.c
@@ -460,7 +460,7 @@ static struct device_attribute koneplus_attributes[] = {
 
 static struct bin_attribute koneplus_bin_attributes[] = {
 	{
-		.attr = { .name = "sensor", .mode = 0220 },
+		.attr = { .name = "sensor", .mode = 0660 },
 		.size = sizeof(struct koneplus_sensor),
 		.read = koneplus_sysfs_read_sensor,
 		.write = koneplus_sysfs_write_sensor
-- 
1.7.3.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] HID: roccat: Corrected mode of sysfs attr 'sensor' from koneplus driver
  2011-03-14 20:43 [PATCH] HID: roccat: Corrected mode of sysfs attr 'sensor' from koneplus driver Stefan Achatz
@ 2011-03-15 14:41 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2011-03-15 14:41 UTC (permalink / raw)
  To: Stefan Achatz; +Cc: linux-input, linux-kernel

On Mon, 14 Mar 2011, Stefan Achatz wrote:

> Mode of sysfs attribute 'sensor' was wrongly set to writeonly.
> Corrected this to readwrite.
> 
> Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
> ---
>  drivers/hid/hid-roccat-koneplus.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-roccat-koneplus.c b/drivers/hid/hid-roccat-koneplus.c
> index a8e2117..33eec74 100644
> --- a/drivers/hid/hid-roccat-koneplus.c
> +++ b/drivers/hid/hid-roccat-koneplus.c
> @@ -460,7 +460,7 @@ static struct device_attribute koneplus_attributes[] = {
>  
>  static struct bin_attribute koneplus_bin_attributes[] = {
>  	{
> -		.attr = { .name = "sensor", .mode = 0220 },
> +		.attr = { .name = "sensor", .mode = 0660 },
>  		.size = sizeof(struct koneplus_sensor),
>  		.read = koneplus_sysfs_read_sensor,
>  		.write = koneplus_sysfs_write_sensor

Applied.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-15 14:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-14 20:43 [PATCH] HID: roccat: Corrected mode of sysfs attr 'sensor' from koneplus driver Stefan Achatz
2011-03-15 14:41 ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).