From: Seth Forshee <seth.forshee@canonical.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: sparse-keymap - report KEY_UNKNOWN for unknown scan codes
Date: Fri, 25 Mar 2011 08:40:01 -0500 [thread overview]
Message-ID: <1301060403-19229-1-git-send-email-seth.forshee@canonical.com> (raw)
In-Reply-To: <20110325073554.GD2590@core.coreip.homeip.net>
On Fri, Mar 25, 2011 at 12:35:54AM -0700, Dmitry Torokhov wrote:
> Hi Seth,
>
> On Wed, Mar 23, 2011 at 04:13:43PM -0500, Seth Forshee wrote:
> >
> > + /* Report an unknown key event as a debugging aid */
> > + unknown_ke.type = KE_KEY;
> > + unknown_ke.code = code;
> > + unknown_ke.keycode = KEY_UNKNOWN;
> > + sparse_keymap_report_entry(dev, &unknown_ke, value, autorelease);
>
> I think it should not depend on autorelease but always automatically
> release KEY_UNKNOWN.
>
> Otherwise I think I'll apply both patches.
Great! Here are the patches with that changed.
next prev parent reply other threads:[~2011-03-25 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 21:13 [PATCH 0/2] sparse-keymap: Emit events useful for key debugging Seth Forshee
2011-03-23 21:13 ` [PATCH 1/2] Input: sparse-keymap - report scancodes with key events Seth Forshee
2011-03-23 21:13 ` [PATCH 2/2] Input: sparse-keymap - report KEY_UNKNOWN for unknown scan codes Seth Forshee
2011-03-25 7:35 ` Dmitry Torokhov
2011-03-25 13:40 ` Seth Forshee [this message]
2011-03-25 13:40 ` [PATCH v2 1/2] Input: sparse-keymap - report scancodes with key events Seth Forshee
2011-03-25 13:40 ` [PATCH v2 2/2] Input: sparse-keymap - report KEY_UNKNOWN for unknown scan codes Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301060403-19229-1-git-send-email-seth.forshee@canonical.com \
--to=seth.forshee@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).