* [PATCH] Input: h3600_ts: fix a leak of the IRQ during init failure
@ 2011-05-01 16:13 Axel Lin
0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2011-05-01 16:13 UTC (permalink / raw)
To: linux-kernel; +Cc: Dmitry Torokhov, linux-input
In h3600ts_connect error path, free_irq() was using ts->dev rather than the
&ts->dev as the data pointer so free_irq() wouldn't have matched.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/input/touchscreen/h3600_ts_input.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/h3600_ts_input.c b/drivers/input/touchscreen/h3600_ts_input.c
index 45f93d0..e45ae38 100644
--- a/drivers/input/touchscreen/h3600_ts_input.c
+++ b/drivers/input/touchscreen/h3600_ts_input.c
@@ -424,8 +424,8 @@ static int h3600ts_connect(struct serio *serio, struct serio_driver *drv)
fail4: serio_close(serio);
fail3: serio_set_drvdata(serio, NULL);
- free_irq(IRQ_GPIO_BITSY_NPOWER_BUTTON, ts->dev);
-fail2: free_irq(IRQ_GPIO_BITSY_ACTION_BUTTON, ts->dev);
+ free_irq(IRQ_GPIO_BITSY_NPOWER_BUTTON, &ts->dev);
+fail2: free_irq(IRQ_GPIO_BITSY_ACTION_BUTTON, &ts->dev);
fail1: input_free_device(input_dev);
kfree(ts);
return err;
--
1.7.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-05-01 16:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-01 16:13 [PATCH] Input: h3600_ts: fix a leak of the IRQ during init failure Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).