linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@avionic-design.de>
To: linux-input@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Kwangwoo Lee <kwlee@mtekvision.com>
Subject: [PATCH 3/5] tsc2007: Introduce poll_delay parameter.
Date: Mon, 16 May 2011 10:33:01 +0200	[thread overview]
Message-ID: <1305534783-4917-3-git-send-email-thierry.reding@avionic-design.de> (raw)
In-Reply-To: <1305534783-4917-1-git-send-email-thierry.reding@avionic-design.de>

Depending on the quality of the touch panel, the time for the X-, X+, Y-
and Y+ inputs to settle may vary. The poll_delay parameter can be used
to override the default of 1 millisecond.

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Kwangwoo Lee <kwlee@mtekvision.com>
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
 drivers/input/touchscreen/tsc2007.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c
index 95d619c..43b5c09 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -27,7 +27,6 @@
 #include <linux/i2c.h>
 #include <linux/i2c/tsc2007.h>
 
-#define TS_POLL_DELAY			1 /* ms delay between samples */
 #define TS_POLL_PERIOD			1 /* ms delay between samples */
 
 #define TSC2007_MEASURE_TEMP0		(0x0 << 4)
@@ -83,6 +82,10 @@ struct tsc2007 {
 	void			(*clear_penirq)(void);
 };
 
+static int poll_delay = 1;
+module_param(poll_delay, int, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(poll_delay, "Delay (in ms) after pen-down event before polling starts");
+
 static int max_rt = MAX_12BIT;
 module_param(max_rt, int, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(max_rt, "Maximum resistance above which samples are ignored");
@@ -245,7 +248,7 @@ static irqreturn_t tsc2007_irq(int irq, void *handle)
 	if (!ts->get_pendown_state || likely(ts->get_pendown_state())) {
 		disable_irq_nosync(ts->irq);
 		schedule_delayed_work(&ts->work,
-				      msecs_to_jiffies(TS_POLL_DELAY));
+				      msecs_to_jiffies(poll_delay));
 	}
 
 	if (ts->clear_penirq)
-- 
1.7.5.1


  parent reply	other threads:[~2011-05-16  8:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16  8:32 [PATCH 1/5] tsc2007: Debounce pressure measurement Thierry Reding
2011-05-16  8:33 ` [PATCH 2/5] tsc2007: Add max_rt module parameter Thierry Reding
2011-05-16 16:53   ` Dmitry Torokhov
2011-05-17  5:46     ` Thierry Reding
2011-05-17  5:58       ` Dmitry Torokhov
2011-05-17  6:59     ` Thierry Reding
2011-05-17  7:24       ` Dmitry Torokhov
2011-05-16  8:33 ` Thierry Reding [this message]
2011-05-16  8:33 ` [PATCH 4/5] tsc2007: Introduce poll_period parameter Thierry Reding
2011-05-16  8:33 ` [PATCH 5/5] tsc2007: Add X, Y and Z fuzz factors to platform data Thierry Reding
2011-05-17  6:02 ` [PATCH 1/5] tsc2007: Debounce pressure measurement Dmitry Torokhov
2011-05-17  6:27   ` Thierry Reding
2011-05-17  6:32     ` Dmitry Torokhov
2011-05-17  6:45       ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305534783-4917-3-git-send-email-thierry.reding@avionic-design.de \
    --to=thierry.reding@avionic-design.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kwlee@mtekvision.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).