linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gerecke <killertofu@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linux Input <linux-input@vger.kernel.org>,
	Ping Cheng <pinglinux@gmail.com>,
	Jason Gerecke <jgerecke@wacom.com>, Dima Zavin <dima@android.com>,
	Jason Gerecke <killertofu@gmail.com>
Subject: [PATCH 2/4] Use MT (in addition to single-touch) protocol for all events
Date: Thu,  7 Jul 2011 14:04:58 -0700	[thread overview]
Message-ID: <1310072700-2829-2-git-send-email-killertofu@gmail.com> (raw)
In-Reply-To: <1310072700-2829-1-git-send-email-killertofu@gmail.com>

Android (begining with Gingerbread) ignores all single-touch events
from multi-touch capable devices. This patch augments the pen and
single-touch handlers to emit MT events for Android's consumption.

Signed-off-by: Jason Gerecke <killertofu@gmail.com>
---
 Now being sent upstream to LKML at the behest of Google.

 drivers/input/touchscreen/wacom_w8001.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touchscreen/wacom_w8001.c
index 7630806..e94a21a 100644
--- a/drivers/input/touchscreen/wacom_w8001.c
+++ b/drivers/input/touchscreen/wacom_w8001.c
@@ -278,6 +278,13 @@ static void report_pen_events(struct w8001 *w8001, struct w8001_coord *coord)
 	input_report_key(dev, BTN_TOUCH, coord->tsw);
 	input_report_key(dev, BTN_STYLUS, coord->f1);
 	input_report_key(dev, w8001->type, coord->rdy);
+
+	input_report_abs(dev, ABS_MT_POSITION_X, coord->x);
+	input_report_abs(dev, ABS_MT_POSITION_Y, coord->y);
+	input_report_abs(dev, ABS_MT_PRESSURE, coord->pen_pressure);
+	input_report_abs(dev, ABS_MT_TOOL_TYPE, MT_TOOL_PEN);
+
+	input_mt_sync(dev);
 	input_sync(dev);
 
 	if (!coord->rdy)
@@ -298,6 +305,11 @@ static void report_single_touch(struct w8001 *w8001, struct w8001_coord *coord)
 	input_report_key(dev, BTN_TOUCH, coord->tsw);
 	input_report_key(dev, BTN_TOOL_FINGER, coord->tsw);
 
+	input_report_abs(dev, ABS_MT_POSITION_X, x);
+	input_report_abs(dev, ABS_MT_POSITION_Y, y);
+	input_report_abs(dev, ABS_MT_TOOL_TYPE, MT_TOOL_FINGER);
+
+	input_mt_sync(dev);
 	input_sync(dev);
 
 	w8001->type = coord->tsw ? BTN_TOOL_FINGER : KEY_RESERVED;
@@ -485,6 +497,8 @@ static int w8001_setup(struct w8001 *w8001)
 						0, touch.y, 0, 0);
 			input_set_abs_params(dev, ABS_MT_TOOL_TYPE,
 						0, MT_TOOL_MAX, 0, 0);
+			input_set_abs_params(dev, ABS_MT_PRESSURE,
+						0, coord.pen_pressure, 0, 0);
 
 			strlcat(w8001->name, " 2FG", sizeof(w8001->name));
 			if (w8001->max_pen_x && w8001->max_pen_y)
-- 
1.7.5.2


  reply	other threads:[~2011-07-07 21:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 21:04 [PATCH 1/4] Revert to anonymous 'type A' MT protocol for touch Jason Gerecke
2011-07-07 21:04 ` Jason Gerecke [this message]
2011-07-07 21:04 ` [PATCH 3/4] Fix hover in Android (Gingerbread) Jason Gerecke
2011-07-08  1:13   ` Jaya Kumar
2011-07-08 21:04     ` Jason Gerecke
2011-07-09  6:16       ` Dima Zavin
2011-07-09  6:15   ` Jeffrey Brown
2011-07-09  6:22     ` Dima Zavin
2011-07-07 21:05 ` [PATCH 4/4] Only report multi-touch when pen is out of range Jason Gerecke
2011-07-09  6:19   ` Jeffrey Brown
2011-07-07 21:35 ` [PATCH 1/4] Revert to anonymous 'type A' MT protocol for touch Dmitry Torokhov
2011-07-07 21:52   ` Dima Zavin
2011-07-07 22:32     ` Jason Gerecke
2011-08-03  4:31     ` Jiejing.Zhang 

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310072700-2829-2-git-send-email-killertofu@gmail.com \
    --to=killertofu@gmail.com \
    --cc=dima@android.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jgerecke@wacom.com \
    --cc=linux-input@vger.kernel.org \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).