[PATCH] Added support for the Wacom Bamboo Pen (CTL-660/K)

[PATCH] Added support for the Wacom Bamboo Pen (CTL-660/K)

[Gerard Braad]

---
 drivers/input/tablet/wacom_wac.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 08ba5ad..23c9a40 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1460,6 +1460,9 @@ static const struct wacom_features wacom_features_0xD3 =
 static const struct wacom_features wacom_features_0xD4 =
 	{ "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200,  255,
 	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+static const struct wacom_features wacom_features_0xD5 =
+	{ "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     21648, 13530, 1023,
+	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD6 =
 	{ "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN,   14720,  9200, 1023,
 	  63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
@@ -1551,6 +1554,7 @@ const struct usb_device_id wacom_ids[] = {
 	{ USB_DEVICE_WACOM(0xD2) },
 	{ USB_DEVICE_WACOM(0xD3) },
 	{ USB_DEVICE_WACOM(0xD4) },
+	{ USB_DEVICE_WACOM(0xD5) },
 	{ USB_DEVICE_WACOM(0xD6) },
 	{ USB_DEVICE_WACOM(0xD7) },
 	{ USB_DEVICE_WACOM(0xD8) },
-- 
1.7.5.2

Re: [PATCH] Added support for the Wacom Bamboo Pen (CTL-660/K)

[Chris Bagwell]

On Sat, Jul 9, 2011 at 2:14 AM, Gerard Braad <me@gbraad.nl> wrote:
> ---
>  drivers/input/tablet/wacom_wac.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index 08ba5ad..23c9a40 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -1460,6 +1460,9 @@ static const struct wacom_features wacom_features_0xD3 =
>  static const struct wacom_features wacom_features_0xD4 =
>        { "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200,  255,
>          63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> +static const struct wacom_features wacom_features_0xD5 =
> +       { "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     21648, 13530, 1023,
> +         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>  static const struct wacom_features wacom_features_0xD6 =
>        { "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN,   14720,  9200, 1023,
>          63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

There is kinda a convention in other Bamboo names to show the tablet
size when multiple sizes exist.  Since it has the same max's as 0xD3,
it looks like this this new pen-only 0xD5 should have "6X8" at end of
its name.

Now that we advertise the resolution with ABS_X/ABS_Y, its not all
that useful of a convention any more.

With or without that modification:

Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>

With this latest addition, 0xD9 is the only remaining whole in 0xD0 to
0xDB series so hopefully we are about done with these Bamboo
additions.

Chris

> @@ -1551,6 +1554,7 @@ const struct usb_device_id wacom_ids[] = {
>        { USB_DEVICE_WACOM(0xD2) },
>        { USB_DEVICE_WACOM(0xD3) },
>        { USB_DEVICE_WACOM(0xD4) },
> +       { USB_DEVICE_WACOM(0xD5) },
>        { USB_DEVICE_WACOM(0xD6) },
>        { USB_DEVICE_WACOM(0xD7) },
>        { USB_DEVICE_WACOM(0xD8) },
> --
> 1.7.5.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html