* [PATCH] input: xilinx_ps2: Add missing of_address.h header
@ 2011-07-13 13:46 Michal Simek
2011-07-13 15:27 ` Grant Likely
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2011-07-13 13:46 UTC (permalink / raw)
To: linux-input; +Cc: linux-kernel, grant.likely, devicetree-discuss, Michal Simek
Add missing header.
Error log:
CC drivers/input/serio/xilinx_ps2.o
drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource'
Signed-off-by: Michal Simek <monstr@monstr.eu>
---
drivers/input/serio/xilinx_ps2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
index 80baa53..d64c5a4 100644
--- a/drivers/input/serio/xilinx_ps2.c
+++ b/drivers/input/serio/xilinx_ps2.c
@@ -23,7 +23,7 @@
#include <linux/init.h>
#include <linux/list.h>
#include <linux/io.h>
-
+#include <linux/of_address.h>
#include <linux/of_device.h>
#include <linux/of_platform.h>
--
1.5.5.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] input: xilinx_ps2: Add missing of_address.h header
2011-07-13 13:46 [PATCH] input: xilinx_ps2: Add missing of_address.h header Michal Simek
@ 2011-07-13 15:27 ` Grant Likely
2011-07-24 13:51 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Grant Likely @ 2011-07-13 15:27 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-input, linux-kernel, devicetree-discuss
On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek <monstr@monstr.eu> wrote:
> Add missing header.
>
> Error log:
> CC drivers/input/serio/xilinx_ps2.o
> drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
> drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource'
>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> drivers/input/serio/xilinx_ps2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
> index 80baa53..d64c5a4 100644
> --- a/drivers/input/serio/xilinx_ps2.c
> +++ b/drivers/input/serio/xilinx_ps2.c
> @@ -23,7 +23,7 @@
> #include <linux/init.h>
> #include <linux/list.h>
> #include <linux/io.h>
> -
> +#include <linux/of_address.h>
> #include <linux/of_device.h>
> #include <linux/of_platform.h>
>
> --
> 1.5.5.6
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] input: xilinx_ps2: Add missing of_address.h header
2011-07-13 15:27 ` Grant Likely
@ 2011-07-24 13:51 ` Michal Simek
2011-07-31 4:12 ` Grant Likely
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2011-07-24 13:51 UTC (permalink / raw)
To: Grant Likely; +Cc: linux-input, linux-kernel, devicetree-discuss
Hi Grant,
can you propose this patch to mainline through your devicetree tree?
Thanks,
Michal
Grant Likely wrote:
> On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek <monstr@monstr.eu> wrote:
>> Add missing header.
>>
>> Error log:
>> CC drivers/input/serio/xilinx_ps2.o
>> drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
>> drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource'
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
>
>> ---
>> drivers/input/serio/xilinx_ps2.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
>> index 80baa53..d64c5a4 100644
>> --- a/drivers/input/serio/xilinx_ps2.c
>> +++ b/drivers/input/serio/xilinx_ps2.c
>> @@ -23,7 +23,7 @@
>> #include <linux/init.h>
>> #include <linux/list.h>
>> #include <linux/io.h>
>> -
>> +#include <linux/of_address.h>
>> #include <linux/of_device.h>
>> #include <linux/of_platform.h>
>>
>> --
>> 1.5.5.6
>>
>>
>
>
>
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] input: xilinx_ps2: Add missing of_address.h header
2011-07-24 13:51 ` Michal Simek
@ 2011-07-31 4:12 ` Grant Likely
2011-08-01 3:10 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Grant Likely @ 2011-07-31 4:12 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-input, linux-kernel, devicetree-discuss
On Sun, Jul 24, 2011 at 03:51:30PM +0200, Michal Simek wrote:
> Hi Grant,
>
> can you propose this patch to mainline through your devicetree tree?
I've got it in a "input/next" branch. Since the input maintainer
doesn't seem to be active on driver patches, I'll send a pull req to
Linus.
g.
>
> Thanks,
> Michal
>
> Grant Likely wrote:
> >On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek <monstr@monstr.eu> wrote:
> >>Add missing header.
> >>
> >>Error log:
> >>CC drivers/input/serio/xilinx_ps2.o
> >>drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
> >>drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource'
> >>
> >>Signed-off-by: Michal Simek <monstr@monstr.eu>
> >
> >Acked-by: Grant Likely <grant.likely@secretlab.ca>
> >
> >>---
> >> drivers/input/serio/xilinx_ps2.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >>diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
> >>index 80baa53..d64c5a4 100644
> >>--- a/drivers/input/serio/xilinx_ps2.c
> >>+++ b/drivers/input/serio/xilinx_ps2.c
> >>@@ -23,7 +23,7 @@
> >> #include <linux/init.h>
> >> #include <linux/list.h>
> >> #include <linux/io.h>
> >>-
> >>+#include <linux/of_address.h>
> >> #include <linux/of_device.h>
> >> #include <linux/of_platform.h>
> >>
> >>--
> >>1.5.5.6
> >>
> >>
> >
> >
> >
>
>
> --
> Michal Simek, Ing. (M.Eng)
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
> Microblaze U-BOOT custodian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] input: xilinx_ps2: Add missing of_address.h header
2011-07-31 4:12 ` Grant Likely
@ 2011-08-01 3:10 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2011-08-01 3:10 UTC (permalink / raw)
To: Grant Likely; +Cc: Michal Simek, linux-input, linux-kernel, devicetree-discuss
On Sat, Jul 30, 2011 at 10:12:30PM -0600, Grant Likely wrote:
> On Sun, Jul 24, 2011 at 03:51:30PM +0200, Michal Simek wrote:
> > Hi Grant,
> >
> > can you propose this patch to mainline through your devicetree tree?
>
> I've got it in a "input/next" branch. Since the input maintainer
> doesn't seem to be active on driver patches, I'll send a pull req to
> Linus.
CCing me on patches usually helps... Yes, please feel free to push
through your tree if you'd like.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-01 3:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-13 13:46 [PATCH] input: xilinx_ps2: Add missing of_address.h header Michal Simek
2011-07-13 15:27 ` Grant Likely
2011-07-24 13:51 ` Michal Simek
2011-07-31 4:12 ` Grant Likely
2011-08-01 3:10 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).