linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: mpu3050 - call  input_free_device() in mpu3050_probe() error handling
@ 2011-07-20  7:38 Axel Lin
  2011-08-11  7:52 ` Axel Lin
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-07-20  7:38 UTC (permalink / raw)
  To: linux-kernel; +Cc: Dmitry Torokhov, Joseph Lai, linux-input

>From 3dcc899388d98a68c22d14b3149d3cc472f8d2fa Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@gmail.com>
Date: Wed, 20 Jul 2011 15:34:33 +0800
Subject: [PATCH] Input: mpu3050 - correct call to input_free_device

input_free_device() should be used if input_register_device() was not called
yet or if it failed.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/input/misc/mpu3050.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/misc/mpu3050.c b/drivers/input/misc/mpu3050.c
index b95fac1..f71dc72 100644
--- a/drivers/input/misc/mpu3050.c
+++ b/drivers/input/misc/mpu3050.c
@@ -282,7 +282,7 @@ err_free_irq:
 err_pm_set_suspended:
 	pm_runtime_set_suspended(&client->dev);
 err_free_mem:
-	input_unregister_device(idev);
+	input_free_device(idev);
 	kfree(sensor);
 	return error;
 }
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Input: mpu3050 - call input_free_device() in mpu3050_probe() error handling
  2011-07-20  7:38 [PATCH] Input: mpu3050 - call input_free_device() in mpu3050_probe() error handling Axel Lin
@ 2011-08-11  7:52 ` Axel Lin
  0 siblings, 0 replies; 2+ messages in thread
From: Axel Lin @ 2011-08-11  7:52 UTC (permalink / raw)
  To: linux-kernel; +Cc: Dmitry Torokhov, Joseph Lai, linux-input

2011/7/20 Axel Lin <axel.lin@gmail.com>:
> From 3dcc899388d98a68c22d14b3149d3cc472f8d2fa Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@gmail.com>
> Date: Wed, 20 Jul 2011 15:34:33 +0800
> Subject: [PATCH] Input: mpu3050 - correct call to input_free_device
>
> input_free_device() should be used if input_register_device() was not called
> yet or if it failed.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
hi Dmitry,
Seems this fix is not yet upstream.

Regards,
Axel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-11  7:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-20  7:38 [PATCH] Input: mpu3050 - call input_free_device() in mpu3050_probe() error handling Axel Lin
2011-08-11  7:52 ` Axel Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).