From: Wanlong Gao <wanlong.gao@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: dmitry.torokhov@gmail.com, sameo@linux.intel.com,
linux-input@vger.kernel.org,
Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [PATCH] drivers:input:free the memory before set it to NULL
Date: Thu, 21 Jul 2011 00:08:21 +0800 [thread overview]
Message-ID: <1311178101.10111.1.camel@Tux> (raw)
In-Reply-To: <20110720165454.1e67a91f@lxorguk.ukuu.org.uk>
On 三, 2011-07-20 at 16:54 +0100, Alan Cox wrote:
> On Wed, 20 Jul 2011 23:41:36 +0800
> Wanlong Gao <wanlong.gao@gmail.com> wrote:
>
> > The memory of the platform driver data should be freed
> > before it was set to NULL.
>
> This seems backwards to me. Currently the reference is invalidated before
> the object, which seems to make more sense.
>
> As there is no locking here it really makes no difference anyway
Hmm...
FYI, I see it. Thanks Alan.
And sorry for making noise.
Wanlong Gao
>
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-20 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 15:41 [PATCH] drivers:input:free the memory before set it to NULL Wanlong Gao
2011-07-20 15:54 ` Alan Cox
2011-07-20 16:08 ` Wanlong Gao [this message]
2011-07-20 16:11 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311178101.10111.1.camel@Tux \
--to=wanlong.gao@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=linux-input@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).