From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanlong Gao Subject: Re: [PATCH] drivers:input:free the memory before set it to NULL Date: Thu, 21 Jul 2011 00:11:02 +0800 Message-ID: <1311178262.10111.2.camel@Tux> References: <1311176496-10026-1-git-send-email-wanlong.gao@gmail.com> <20110720165454.1e67a91f@lxorguk.ukuu.org.uk> Reply-To: wanlong.gao@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:64710 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173Ab1GTQLH (ORCPT ); Wed, 20 Jul 2011 12:11:07 -0400 Received: by iwn6 with SMTP id 6so310142iwn.19 for ; Wed, 20 Jul 2011 09:11:07 -0700 (PDT) In-Reply-To: <20110720165454.1e67a91f@lxorguk.ukuu.org.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Alan Cox Cc: dmitry.torokhov@gmail.com, sameo@linux.intel.com, linux-input@vger.kernel.org, Wanlong Gao On =E4=B8=89, 2011-07-20 at 16:54 +0100, Alan Cox wrote: > On Wed, 20 Jul 2011 23:41:36 +0800 > Wanlong Gao wrote: >=20 > > The memory of the platform driver data should be freed > > before it was set to NULL. >=20 > This seems backwards to me. Currently the reference is invalidated be= fore > the object, which seems to make more sense. >=20 > As there is no locking here it really makes no difference anyway BTW, your email head icon is so cool. Thanks Wanlong Gao >=20 > >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html