From: jeffbrown@android.com
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
rydberg@euromail.se, chatty@enac.fr, benjamin.tissoires@enac.fr,
Jeff Brown <jeffbrown@google.com>,
jeffbrown@android.com
Subject: [PATCH 2/3] hid-multitouch: Filter collections by application usage.
Date: Sun, 24 Jul 2011 15:07:40 -0700 [thread overview]
Message-ID: <1311545261-34067-2-git-send-email-jeffbrown@android.com> (raw)
In-Reply-To: <1311545261-34067-1-git-send-email-jeffbrown@android.com>
From: Jeff Brown <jeffbrown@google.com>
This change fixes two problems.
First, it ensures that the hid-multitouch driver does not incorrectly
map GenericDesktop usages that are intended for other applications,
such as a Mouse.
Second, it sets the appropriate input properties so that user-space
can distinguish TouchScreen devices (INPUT_PROP_DIRECT) from
TouchPad devices (INPUT_PROP_POINTER) and configure them accordingly.
Signed-off-by: jeffbrown@android.com
---
drivers/hid/hid-multitouch.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 58d0e7a..4ee21ac 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -213,6 +213,16 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
struct mt_class *cls = td->mtclass;
__s32 quirks = cls->quirks;
+ /* Only map fields from TouchScreen or TouchPad collections.
+ * We need to ignore fields that belong to other collections
+ * such as Mouse that might have the same GenericDesktop usages. */
+ if (field->application == HID_DG_TOUCHSCREEN)
+ set_bit(INPUT_PROP_DIRECT, hi->input->propbit);
+ else if (field->application == HID_DG_TOUCHPAD)
+ set_bit(INPUT_PROP_POINTER, hi->input->propbit);
+ else
+ return 0;
+
switch (usage->hid & HID_USAGE_PAGE) {
case HID_UP_GENDESK:
--
1.7.0.4
next prev parent reply other threads:[~2011-07-24 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 22:07 [PATCH 1/3] hid-debug: Show application usage for each collection jeffbrown
[not found] ` <131154 5261-34067-2-git-send-email-jeffbrown@android.com>
2011-07-24 22:07 ` jeffbrown [this message]
2011-07-25 9:16 ` [PATCH 2/3] hid-multitouch: Filter collections by application usage Stéphane Chatty
2011-07-25 9:29 ` Benjamin Tissoires
2011-07-25 13:48 ` Stéphane Chatty
2011-07-25 18:08 ` Jeffrey Brown
[not found] ` <CAMu+ixi4gpKg=LW4o2nK7NDm4r+B368qh=fSvtndKfqf204K9A@mail.gmail. com>
2011-07-25 18:47 ` Stéphane Chatty
2011-07-27 12:43 ` Stéphane Chatty
2011-07-24 22:07 ` [PATCH 3/3] hid-multitouch: Add LG Display Multitouch device jeffbrown
2011-07-25 9:18 ` Stéphane Chatty
2011-07-25 9:32 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311545261-34067-2-git-send-email-jeffbrown@android.com \
--to=jeffbrown@android.com \
--cc=benjamin.tissoires@enac.fr \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jeffbrown@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).