* [PATCH 1/2] HID: kfree() NULL pointer cleanup
@ 2011-08-04 20:42 Bojan Prtvar
2011-08-04 20:48 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Bojan Prtvar @ 2011-08-04 20:42 UTC (permalink / raw)
To: jkosina; +Cc: linux-input, linux-kernel, kernel-janitors, Bojan Prtvar
Checking for NULL pointers before kfree() is redundant.
Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
---
drivers/hid/hid-prodikeys.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index 158b389..62f95d4 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c
@@ -849,9 +849,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
err_stop:
hid_hw_stop(hdev);
err_free:
- if (pm != NULL)
- kfree(pm);
-
+ kfree(pm);
kfree(pk);
return ret;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] HID: kfree() NULL pointer cleanup
2011-08-04 20:42 [PATCH 1/2] HID: kfree() NULL pointer cleanup Bojan Prtvar
@ 2011-08-04 20:48 ` Julia Lawall
2011-08-04 21:16 ` bojan prtvar
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2011-08-04 20:48 UTC (permalink / raw)
To: Bojan Prtvar; +Cc: jkosina, linux-input, linux-kernel, kernel-janitors
On Thu, 4 Aug 2011, Bojan Prtvar wrote:
> Checking for NULL pointers before kfree() is redundant.
I would find it even nicer to just add a new lavel to skip over the kfree
in the case where pm is NULL. It is statically apparent in the source
code.
julia
> Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
> ---
> drivers/hid/hid-prodikeys.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
> index 158b389..62f95d4 100644
> --- a/drivers/hid/hid-prodikeys.c
> +++ b/drivers/hid/hid-prodikeys.c
> @@ -849,9 +849,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
> err_stop:
> hid_hw_stop(hdev);
> err_free:
> - if (pm != NULL)
> - kfree(pm);
> -
> + kfree(pm);
> kfree(pk);
> return ret;
> }
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] HID: kfree() NULL pointer cleanup
2011-08-04 20:48 ` Julia Lawall
@ 2011-08-04 21:16 ` bojan prtvar
0 siblings, 0 replies; 3+ messages in thread
From: bojan prtvar @ 2011-08-04 21:16 UTC (permalink / raw)
To: Julia Lawall; +Cc: jkosina, linux-input, linux-kernel, kernel-janitors
On Thu, Aug 4, 2011 at 10:48 PM, Julia Lawall <julia@diku.dk> wrote:
> On Thu, 4 Aug 2011, Bojan Prtvar wrote:
>
> I would find it even nicer to just add a new lavel to skip over the kfree
> in the case where pm is NULL. It is statically apparent in the source
> code.
Yes, it would be nicer. I'll send v2.
Regards,
Bojan
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-04 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-04 20:42 [PATCH 1/2] HID: kfree() NULL pointer cleanup Bojan Prtvar
2011-08-04 20:48 ` Julia Lawall
2011-08-04 21:16 ` bojan prtvar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).