* [PATCH 2/2] HID: kfree() NULL pointer cleanup
@ 2011-08-04 20:43 Bojan Prtvar
2011-08-04 21:46 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Bojan Prtvar @ 2011-08-04 20:43 UTC (permalink / raw)
To: jkosina; +Cc: linux-input, linux-kernel, kernel-janitors, Bojan Prtvar
Checking for NULL pointers before kfree() is redundant.
Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
---
drivers/hid/hid-zydacron.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-zydacron.c b/drivers/hid/hid-zydacron.c
index e903715..1ad85f2 100644
--- a/drivers/hid/hid-zydacron.c
+++ b/drivers/hid/hid-zydacron.c
@@ -201,9 +201,7 @@ static void zc_remove(struct hid_device *hdev)
struct zc_device *zc = hid_get_drvdata(hdev);
hid_hw_stop(hdev);
-
- if (NULL != zc)
- kfree(zc);
+ kfree(zc);
}
static const struct hid_device_id zc_devices[] = {
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/2] HID: kfree() NULL pointer cleanup
2011-08-04 20:43 [PATCH 2/2] HID: kfree() NULL pointer cleanup Bojan Prtvar
@ 2011-08-04 21:46 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2011-08-04 21:46 UTC (permalink / raw)
To: Bojan Prtvar; +Cc: linux-input, linux-kernel, kernel-janitors
On Thu, 4 Aug 2011, Bojan Prtvar wrote:
> Checking for NULL pointers before kfree() is redundant.
>
> Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
> ---
> drivers/hid/hid-zydacron.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-zydacron.c b/drivers/hid/hid-zydacron.c
> index e903715..1ad85f2 100644
> --- a/drivers/hid/hid-zydacron.c
> +++ b/drivers/hid/hid-zydacron.c
> @@ -201,9 +201,7 @@ static void zc_remove(struct hid_device *hdev)
> struct zc_device *zc = hid_get_drvdata(hdev);
>
> hid_hw_stop(hdev);
> -
> - if (NULL != zc)
> - kfree(zc);
> + kfree(zc);
> }
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-04 21:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-04 20:43 [PATCH 2/2] HID: kfree() NULL pointer cleanup Bojan Prtvar
2011-08-04 21:46 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).