From: JJ Ding <jj_ding@emc.com.tw>
To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Seth Forshee" <seth.forshee@canonical.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Aaron Huang" <aaron_huang@emc.com.tw>,
"Tom Lin" <tom_lin@emc.com.tw>,
"Éric Piel" <E.A.B.Piel@tudelft.nl>,
"Daniel Kurtz" <djkurtz@chromium.org>,
"Chase Douglas" <chase.douglas@canonical.com>,
"Henrik Rydberg" <rydberg@euromail.se>,
"Alessandro Rubini" <rubini@cvml.unipv.it>,
"JJ Ding" <jj_ding@emc.com.tw>
Subject: [PATCH v2 1/7] Input: elantech - correct x, y value range for v2 hardware
Date: Wed, 24 Aug 2011 13:44:40 +0800 [thread overview]
Message-ID: <1314164686-866-2-git-send-email-jj_ding@emc.com.tw> (raw)
In-Reply-To: <1314164686-866-1-git-send-email-jj_ding@emc.com.tw>
x, y values are actually 12-bit long. Also update protocol document to reflect
the change.
Signed-off-by: JJ Ding <jj_ding@emc.com.tw>
---
Documentation/input/elantech.txt | 8 ++++----
drivers/input/mouse/elantech.c | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/input/elantech.txt b/Documentation/input/elantech.txt
index db798af..bce9941 100644
--- a/Documentation/input/elantech.txt
+++ b/Documentation/input/elantech.txt
@@ -389,14 +389,14 @@ byte 0:
byte 1:
bit 7 6 5 4 3 2 1 0
- p7 p6 p5 p4 . x10 x9 x8
+ p7 p6 p5 p4 x11 x10 x9 x8
byte 2:
bit 7 6 5 4 3 2 1 0
x7 x6 x5 x4 x3 x2 x1 x0
- x10..x0 = absolute x value (horizontal)
+ x11..x0 = absolute x value (horizontal)
byte 3:
@@ -420,7 +420,7 @@ byte 3:
byte 4:
bit 7 6 5 4 3 2 1 0
- p3 p1 p2 p0 . . y9 y8
+ p3 p1 p2 p0 y11 y10 y9 y8
p7..p0 = pressure (not EF113)
@@ -429,7 +429,7 @@ byte 5:
bit 7 6 5 4 3 2 1 0
y7 y6 y5 y4 y3 y2 y1 y0
- y9..y0 = absolute y value (vertical)
+ y11..y0 = absolute y value (vertical)
4.2.2 Two finger touch
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 3250356..da161da 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -290,15 +290,15 @@ static void elantech_report_absolute_v2(struct psmouse *psmouse)
/* pass through... */
case 1:
/*
- * byte 1: . . . . . x10 x9 x8
+ * byte 1: . . . . x11 x10 x9 x8
* byte 2: x7 x6 x5 x4 x4 x2 x1 x0
*/
- x1 = ((packet[1] & 0x07) << 8) | packet[2];
+ x1 = ((packet[1] & 0x0f) << 8) | packet[2];
/*
- * byte 4: . . . . . . y9 y8
+ * byte 4: . . . . y11 y10 y9 y8
* byte 5: y7 y6 y5 y4 y3 y2 y1 y0
*/
- y1 = ETP_YMAX_V2 - (((packet[4] & 0x03) << 8) | packet[5]);
+ y1 = ETP_YMAX_V2 - (((packet[4] & 0x0f) << 8) | packet[5]);
input_report_abs(dev, ABS_X, x1);
input_report_abs(dev, ABS_Y, y1);
--
1.7.4.1
next prev parent reply other threads:[~2011-08-24 5:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 5:44 [PATCH v2 0/7] Input: elantech: add support for newer hardware JJ Ding
2011-08-24 5:44 ` JJ Ding [this message]
2011-08-24 5:44 ` [PATCH v2 2/7] Input: elantech - get rid of ETP_2FT_* in elantech.h JJ Ding
2011-08-24 5:44 ` [PATCH v2 3/7] Input: elantech - use firmware provided x, y ranges JJ Ding
2011-08-24 5:44 ` [PATCH v2 4/7] Input: elantech - remove ETP_EDGE_FUZZ_V2 JJ Ding
2011-08-24 5:44 ` [PATCH v2 5/7] Input: elantech - packet checking for v2 hardware JJ Ding
2011-08-24 5:44 ` [PATCH v2 6/7] Input: elantech - clean up elantech_init JJ Ding
2011-08-24 5:44 ` [PATCH v2 7/7] Input: elantech - add v3 hardware support JJ Ding
2011-08-24 14:35 ` Seth Forshee
2011-08-25 1:09 ` JJ Ding
2011-08-25 7:06 ` Dmitry Torokhov
2011-08-25 8:22 ` JJ Ding
-- strict thread matches above, loose matches on Subject: below --
2011-08-24 5:38 [PATCH v2 0/7] Input: elantech: add support for newer hardware JJ Ding
2011-08-24 5:38 ` [PATCH v2 1/7] Input: elantech - correct x, y value range for v2 hardware JJ Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314164686-866-2-git-send-email-jj_ding@emc.com.tw \
--to=jj_ding@emc.com.tw \
--cc=E.A.B.Piel@tudelft.nl \
--cc=aaron_huang@emc.com.tw \
--cc=chase.douglas@canonical.com \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@cvml.unipv.it \
--cc=rydberg@euromail.se \
--cc=seth.forshee@canonical.com \
--cc=tom_lin@emc.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).