* [PATCH] Input: adp5588-keys - remove incorrect modalias
@ 2011-08-25 10:30 Axel Lin
2011-08-25 10:43 ` Hennerich, Michael
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2011-08-25 10:30 UTC (permalink / raw)
To: linux-kernel
Cc: Michael Hennerich, Dmitry Torokhov, device-drivers-devel,
linux-input
>From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@gmail.com>
Date: Thu, 25 Aug 2011 18:26:56 +0800
Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias
For i2c drivers, we should use "i2c:" prefix for modalias.
MODULE_DEVICE_TABLE will setup the modulalias for us,
thus adding a MODULE_ALIAS here seems redundant.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/input/keyboard/adp5588-keys.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
index 7b404e54..e34eeb8 100644
--- a/drivers/input/keyboard/adp5588-keys.c
+++ b/drivers/input/keyboard/adp5588-keys.c
@@ -668,4 +668,3 @@ module_exit(adp5588_exit);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
MODULE_DESCRIPTION("ADP5588/87 Keypad driver");
-MODULE_ALIAS("platform:adp5588-keys");
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] Input: adp5588-keys - remove incorrect modalias
2011-08-25 10:30 [PATCH] Input: adp5588-keys - remove incorrect modalias Axel Lin
@ 2011-08-25 10:43 ` Hennerich, Michael
2011-08-27 6:32 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Hennerich, Michael @ 2011-08-25 10:43 UTC (permalink / raw)
To: Axel Lin, linux-kernel@vger.kernel.org
Cc: Dmitry Torokhov, device-drivers-devel@blackfin.uclinux.org,
linux-input@vger.kernel.org
Axel Lin wrote on 2011-08-25:
> From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@gmail.com>
> Date: Thu, 25 Aug 2011 18:26:56 +0800
> Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias
>
> For i2c drivers, we should use "i2c:" prefix for modalias.
> MODULE_DEVICE_TABLE will setup the modulalias for us,
> thus adding a MODULE_ALIAS here seems redundant.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/input/keyboard/adp5588-keys.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
> diff --git a/drivers/input/keyboard/adp5588-keys.c
> b/drivers/input/keyboard/adp5588-keys.c index 7b404e54..e34eeb8 100644
> --- a/drivers/input/keyboard/adp5588-keys.c +++
> b/drivers/input/keyboard/adp5588-keys.c @@ -668,4 +668,3 @@
> module_exit(adp5588_exit);
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
> MODULE_DESCRIPTION("ADP5588/87 Keypad driver");
> -MODULE_ALIAS("platform:adp5588-keys");
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Input: adp5588-keys - remove incorrect modalias
2011-08-25 10:43 ` Hennerich, Michael
@ 2011-08-27 6:32 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2011-08-27 6:32 UTC (permalink / raw)
To: Hennerich, Michael
Cc: Axel Lin, linux-kernel@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org,
linux-input@vger.kernel.org
On Thu, Aug 25, 2011 at 11:43:53AM +0100, Hennerich, Michael wrote:
> Axel Lin wrote on 2011-08-25:
> > From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
> > From: Axel Lin <axel.lin@gmail.com>
> > Date: Thu, 25 Aug 2011 18:26:56 +0800
> > Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias
> >
> > For i2c drivers, we should use "i2c:" prefix for modalias.
> > MODULE_DEVICE_TABLE will setup the modulalias for us,
> > thus adding a MODULE_ALIAS here seems redundant.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Applied, thanks Axel.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-27 6:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-25 10:30 [PATCH] Input: adp5588-keys - remove incorrect modalias Axel Lin
2011-08-25 10:43 ` Hennerich, Michael
2011-08-27 6:32 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).