[PATCH 1/4] input: wacom - Lower the LED luminance

[PATCH 1/4] input: wacom - Lower the LED luminance

[Ping Cheng]

The LED luminance level is normally lower when no button is pressed.

Reviewed-by: Eduard Hasenleithner <eduard@hasenleithner.at>
Tested-by: Eduard Hasenleithner <eduard@hasenleithner.at>
Signed-off-by: Ping Cheng <pingc@wacom.com>
---
 Documentation/ABI/testing/sysfs-driver-wacom |    3 ++-
 drivers/input/tablet/wacom_sys.c             |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-driver-wacom b/Documentation/ABI/testing/sysfs-driver-wacom
index dfe1d46..b1d5c17 100644
--- a/Documentation/ABI/testing/sysfs-driver-wacom
+++ b/Documentation/ABI/testing/sysfs-driver-wacom
@@ -25,7 +25,8 @@ Contact:	linux-input@vger.kernel.org
 Description:
 		Writing to this file sets the status LED luminance (0..127)
 		when the stylus does not touch the tablet surface, and no
-		button is pressed on the stylus.
+		button is pressed on the stylus. This luminance level is
+		normally lower than the level when a button is pressed.
 
 What:		/sys/bus/usb/devices/<busnum>-<devnum>:<cfg>.<intf>/wacom_led/status1_luminance
 Date:		August 2011
diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
index 0eccf57..7facacc 100644
--- a/drivers/input/tablet/wacom_sys.c
+++ b/drivers/input/tablet/wacom_sys.c
@@ -678,7 +678,7 @@ static int wacom_initialize_leds(struct wacom *wacom)
 
 		/* Initialize default values */
 		wacom->led.select = 0;
-		wacom->led.llv = 30;
+		wacom->led.llv = 10;
 		wacom->led.hlv = 20;
 		wacom->led.img_lum = 10;
 		wacom_led_control(wacom);
-- 
1.7.6

Re: [PATCH 1/4] input: wacom - Lower the LED luminance

[Ping Cheng]

All four patches in this set were reviewed-by and signed-off-by Eduard
Hasenleithner. Somehow I missed those tags in the other patches.

Ping

On Mon, Oct 3, 2011 at 5:02 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> The LED luminance level is normally lower when no button is pressed.
>
> Reviewed-by: Eduard Hasenleithner <eduard@hasenleithner.at>
> Tested-by: Eduard Hasenleithner <eduard@hasenleithner.at>
> Signed-off-by: Ping Cheng <pingc@wacom.com>
> ---
>  Documentation/ABI/testing/sysfs-driver-wacom |    3 ++-
>  drivers/input/tablet/wacom_sys.c             |    2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-wacom b/Documentation/ABI/testing/sysfs-driver-wacom
> index dfe1d46..b1d5c17 100644
> --- a/Documentation/ABI/testing/sysfs-driver-wacom
> +++ b/Documentation/ABI/testing/sysfs-driver-wacom
> @@ -25,7 +25,8 @@ Contact:      linux-input@vger.kernel.org
>  Description:
>                Writing to this file sets the status LED luminance (0..127)
>                when the stylus does not touch the tablet surface, and no
> -               button is pressed on the stylus.
> +               button is pressed on the stylus. This luminance level is
> +               normally lower than the level when a button is pressed.
>
>  What:          /sys/bus/usb/devices/<busnum>-<devnum>:<cfg>.<intf>/wacom_led/status1_luminance
>  Date:          August 2011
> diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
> index 0eccf57..7facacc 100644
> --- a/drivers/input/tablet/wacom_sys.c
> +++ b/drivers/input/tablet/wacom_sys.c
> @@ -678,7 +678,7 @@ static int wacom_initialize_leds(struct wacom *wacom)
>
>                /* Initialize default values */
>                wacom->led.select = 0;
> -               wacom->led.llv = 30;
> +               wacom->led.llv = 10;
>                wacom->led.hlv = 20;
>                wacom->led.img_lum = 10;
>                wacom_led_control(wacom);
> --
> 1.7.6
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html