From: Thomas Abraham <thomas.abraham@linaro.org>
To: devicetree-discuss@lists.ozlabs.org, dmitry.torokhov@gmail.com
Cc: grant.likely@secretlab.ca, linux-input@vger.kernel.org,
kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jy0922.shim@samsung.com,
dh09.lee@samsung.com, patches@linaro.org
Subject: [PATCH v5 0/2] Add device tree support for Samsung's keypad controller driver
Date: Mon, 10 Oct 2011 21:59:55 +0530 [thread overview]
Message-ID: <1318264197-6698-1-git-send-email-thomas.abraham@linaro.org> (raw)
Changes since v4:
- Tested with linux 3.1-rc9. No changes in code.
Changes since v3:
- Addressed comments from Grant Likely.
- Set num_rows and num_cols to zero in samsung_keypad_parse_dt function.
- Fixed the wierd looking if-else block in samsung_keypad_probe function.
Changes since v2:
- Addressed comments from Grant Likely.
- Renamed 'keypad,key-code' property name to 'linux,code'.
- Fixed incorrect data types for all instances of of_property+read_u32.
- linux,input-type binding was not added as suggested since the driver
supports only EV_KEY event type.
Changes since v1:
- Addressed comments from Dmitry Torokhov.
- Type of controller is cached in driver's private data and the function
that determines the type of the controller for each keypad scan is
removed.
- pdata allocated during probe is explicitly freed after probe completes
without any error. In case of exit from probe due a error, no explicit
deallocation of pdata memory is performed and it is left to devres to
handle that.
- The generic code to translate KEY(x,y,code) is retained in the driver
itself. I am unsure of a right common place for it.
- Driver continues with the probe even if one or more gpio configuration
fails.
- Patch 1 that adds a new config option is still retained in this patchset.
This patchset adds device tree support for samsung's keypad controller driver.
First patch adds a new config option to be used by device tree enabled platforms
for selecting the samsung's keypad controller driver. The second patch adds device
tree support for the keypad driver.
Thomas Abraham (2):
input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option
input: samsung-keypad: Add device tree support
.../devicetree/bindings/input/samsung-keypad.txt | 88 ++++++++++
drivers/input/keyboard/Kconfig | 9 +-
drivers/input/keyboard/samsung-keypad.c | 174 ++++++++++++++++++--
3 files changed, 258 insertions(+), 13 deletions(-)
create mode 100644 Documentation/devicetree/bindings/input/samsung-keypad.txt
next reply other threads:[~2011-10-10 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 16:29 Thomas Abraham [this message]
2011-10-10 16:29 ` [PATCH v5 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option Thomas Abraham
2011-10-10 16:29 ` [PATCH v5 2/2] input: samsung-keypad: Add device tree support Thomas Abraham
2011-12-28 7:28 ` Olof Johansson
2011-10-11 12:09 ` [PATCH v5 0/2] Add device tree support for Samsung's keypad controller driver Kukjin Kim
2011-10-24 13:00 ` Kukjin Kim
2011-11-02 11:27 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318264197-6698-1-git-send-email-thomas.abraham@linaro.org \
--to=thomas.abraham@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dh09.lee@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).