From: Seth Forshee <seth.forshee@canonical.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Alessandro Rubini <rubini@ipvvis.unipv.it>,
Henrik Rydberg <rydberg@euromail.se>,
Chase Douglas <chase.douglas@canonical.com>,
Andrew Skalski <askalski@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/7] Input: ALPS - Remove assumptions about packet size
Date: Mon, 7 Nov 2011 14:52:37 -0600 [thread overview]
Message-ID: <1320699160-28492-5-git-send-email-seth.forshee@canonical.com> (raw)
In-Reply-To: <1320699160-28492-1-git-send-email-seth.forshee@canonical.com>
In preparation for version 4 protocol support, which has 8-byte
data packets, remove all hard-coded assumptions about packet size
and use psmouse->pktsize instead.
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
---
drivers/input/mouse/alps.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index 77b776d..44a0a71 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -308,7 +308,7 @@ static void alps_flush_packet(unsigned long data)
serio_pause_rx(psmouse->ps2dev.serio);
- if (psmouse->pktcnt == 6) {
+ if (psmouse->pktcnt == psmouse->pktsize) {
/*
* We did not any more data in reasonable amount of time.
@@ -359,8 +359,8 @@ static psmouse_ret_t alps_process_byte(struct psmouse *psmouse)
return PSMOUSE_BAD_DATA;
}
- /* Bytes 2 - 6 should have 0 in the highest bit */
- if (psmouse->pktcnt >= 2 && psmouse->pktcnt <= 6 &&
+ /* Bytes 2 - pktsize should have 0 in the highest bit */
+ if (psmouse->pktcnt >= 2 && psmouse->pktcnt <= psmouse->pktsize &&
(psmouse->packet[psmouse->pktcnt - 1] & 0x80)) {
psmouse_dbg(psmouse, "refusing packet[%i] = %x\n",
psmouse->pktcnt - 1,
@@ -368,7 +368,7 @@ static psmouse_ret_t alps_process_byte(struct psmouse *psmouse)
return PSMOUSE_BAD_DATA;
}
- if (psmouse->pktcnt == 6) {
+ if (psmouse->pktcnt == psmouse->pktsize) {
alps_process_packet(psmouse);
return PSMOUSE_FULL_PACKET;
}
@@ -529,7 +529,7 @@ static int alps_tap_mode(struct psmouse *psmouse, int enable)
static int alps_poll(struct psmouse *psmouse)
{
struct alps_data *priv = psmouse->private;
- unsigned char buf[6];
+ unsigned char buf[sizeof(psmouse->packet)];
bool poll_failed;
if (priv->i->flags & ALPS_PASS)
--
1.7.5.4
next prev parent reply other threads:[~2011-11-07 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 20:52 [PATCH v2 0/7] Additional ALPS touchpad protocol support Seth Forshee
2011-11-07 20:52 ` [PATCH v2 1/7] Input: ALPS - Move protocol information to Documentation Seth Forshee
2011-11-07 20:52 ` [PATCH v2 2/7] Input: psmouse - Add PSMOUSE_CMD_RESET_WRAP Seth Forshee
2011-11-07 20:52 ` [PATCH v2 3/7] Input: ALPS - Add protocol version field in alps_model_info Seth Forshee
2011-11-07 20:52 ` Seth Forshee [this message]
2011-11-07 21:31 ` [PATCH v2 4/7] Input: ALPS - Remove assumptions about packet size Chase Douglas
2011-11-07 20:52 ` [PATCH v2 5/7] Input: ALPS - Add support for protocol versions 3 and 4 Seth Forshee
2011-11-07 20:52 ` [PATCH v2 6/7] Input: ALPS - Add semi-MT support for v3 protocol Seth Forshee
2011-11-07 20:52 ` [PATCH v2 7/7] Input: ALPS - Add documentation for protocol versions 3 and 4 Seth Forshee
2011-11-08 3:55 ` [PATCH v2 0/7] Additional ALPS touchpad protocol support Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320699160-28492-5-git-send-email-seth.forshee@canonical.com \
--to=seth.forshee@canonical.com \
--cc=askalski@gmail.com \
--cc=chase.douglas@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@ipvvis.unipv.it \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).