From: JJ Ding <jj_ding@emc.com.tw>
To: linux-input@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
JJ Ding <jj_ding@emc.com.tw>, JJ Ding <dgdunix@gmail.com>
Subject: [RFC PATCH 1/2] Input: psmouse - work around EC buffer
Date: Wed, 7 Dec 2011 19:38:43 +0800 [thread overview]
Message-ID: <1323257924-12773-2-git-send-email-jj_ding@emc.com.tw> (raw)
In-Reply-To: <1323257924-12773-1-git-send-email-jj_ding@emc.com.tw>
From: JJ Ding <dgdunix@gmail.com>
With some EC chips, when we resync due to bad packets, those bad bytes would
still remain in EC's buffer area. That makes us always get bad data back,
no matter what.
So shift packet for 1 byte when encounter bad packet, until we get rid of
those bytes.
Signed-off-by: JJ Ding <dgdunix@gmail.com>
---
drivers/input/mouse/psmouse-base.c | 5 +++++
drivers/input/mouse/psmouse.h | 3 ++-
2 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
index 200be9c..b849cec 100644
--- a/drivers/input/mouse/psmouse-base.c
+++ b/drivers/input/mouse/psmouse-base.c
@@ -279,6 +279,11 @@ static int psmouse_handle_byte(struct psmouse *psmouse)
}
break;
+ case PSMOUSE_SHIFT_PACKET:
+ memmove(psmouse->packet, psmouse->packet + 1, psmouse->pktsize - 1);
+ psmouse->pktcnt--;
+ break;
+
case PSMOUSE_GOOD_DATA:
break;
}
diff --git a/drivers/input/mouse/psmouse.h b/drivers/input/mouse/psmouse.h
index 6a41709..1742c1b 100644
--- a/drivers/input/mouse/psmouse.h
+++ b/drivers/input/mouse/psmouse.h
@@ -33,7 +33,8 @@ enum psmouse_state {
typedef enum {
PSMOUSE_BAD_DATA,
PSMOUSE_GOOD_DATA,
- PSMOUSE_FULL_PACKET
+ PSMOUSE_FULL_PACKET,
+ PSMOUSE_SHIFT_PACKET
} psmouse_ret_t;
struct psmouse {
--
1.7.8
next prev parent reply other threads:[~2011-12-07 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 11:38 [RFC PATCH 0/2] Input: psmouse - new mechanism for bad packet handling JJ Ding
2011-12-07 11:38 ` JJ Ding [this message]
2011-12-07 11:38 ` [RFC PATCH 2/2] Input: elantech - convert v1 ~ v3 hardware to use PSMOUSE_SHIFT_PACKET JJ Ding
2012-01-29 11:11 ` [RFC PATCH 0/2] Input: psmouse - new mechanism for bad packet handling Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323257924-12773-2-git-send-email-jj_ding@emc.com.tw \
--to=jj_ding@emc.com.tw \
--cc=dgdunix@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).