[PATCH] HID: wacom: Force new name for Wacom Intuos4 WL PTK-540WL

[PATCH] HID: wacom: Force new name for Wacom Intuos4 WL PTK-540WL

[Przemo Firszt]

The name reported by Inutos4 WL connected by bluetooth is "PTK-540WL" and
to make it consistent with other Wacom devices it has to be converted to
"Wacom Intuos4 WL". It also makes userland applications aware that it's
a Wacom device.

Signed-off-by: Przemo Firszt <przemo@firszt.eu>
---
 drivers/hid/hid-wacom.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index acab74c..0621047 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -518,6 +518,7 @@ static int wacom_probe(struct hid_device *hdev,
 		wacom_poke(hdev, 1);
 		break;
 	case USB_DEVICE_ID_WACOM_INTUOS4_BLUETOOTH:
+		sprintf(hdev->name, "%s", "Wacom Intuos4 WL");
 		wdata->features = 0;
 		wacom_set_features(hdev);
 		break;
-- 
1.7.6.4

Re: [PATCH] HID: wacom: Force new name for Wacom Intuos4 WL PTK-540WL

[Chris Bagwell]

On Fri, Feb 17, 2012 at 11:47 AM, Przemo Firszt <przemo@firszt.eu> wrote:
> The name reported by Inutos4 WL connected by bluetooth is "PTK-540WL" and
> to make it consistent with other Wacom devices it has to be converted to
> "Wacom Intuos4 WL". It also makes userland applications aware that it's
> a Wacom device.
>
> Signed-off-by: Przemo Firszt <przemo@firszt.eu>
> ---

Its worth noting this aligns naming of device to same used when this
device is plugged into USB port and controlled by USB wacom driver;
and thus helps align userland logic to route to apps like
xf86-input-wacom.

Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>

>  drivers/hid/hid-wacom.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> index acab74c..0621047 100644
> --- a/drivers/hid/hid-wacom.c
> +++ b/drivers/hid/hid-wacom.c
> @@ -518,6 +518,7 @@ static int wacom_probe(struct hid_device *hdev,
>                wacom_poke(hdev, 1);
>                break;
>        case USB_DEVICE_ID_WACOM_INTUOS4_BLUETOOTH:
> +               sprintf(hdev->name, "%s", "Wacom Intuos4 WL");
>                wdata->features = 0;
>                wacom_set_features(hdev);
>                break;
> --
> 1.7.6.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: wacom: Force new name for Wacom Intuos4 WL PTK-540WL

[Jiri Kosina]

On Fri, 17 Feb 2012, Chris Bagwell wrote:

> On Fri, Feb 17, 2012 at 11:47 AM, Przemo Firszt <przemo@firszt.eu> wrote:
> > The name reported by Inutos4 WL connected by bluetooth is "PTK-540WL" and
> > to make it consistent with other Wacom devices it has to be converted to
> > "Wacom Intuos4 WL". It also makes userland applications aware that it's
> > a Wacom device.
> >
> > Signed-off-by: Przemo Firszt <przemo@firszt.eu>
> > ---
> 
> Its worth noting this aligns naming of device to same used when this
> device is plugged into USB port and controlled by USB wacom driver;
> and thus helps align userland logic to route to apps like
> xf86-input-wacom.
> 
> Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>

I have updated changelog to include the comment from Chris and applied, 
thanks everybody.

-- 
Jiri Kosina
SUSE Labs