From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: add ThingM blink(1) USB LED support
Date: Mon, 21 Jan 2013 12:14:01 -0500 (EST) [thread overview]
Message-ID: <1329559360.389477.1358788441066.JavaMail.root@mail.savoirfairelinux.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1301211714520.8266@pobox.suse.cz>
Hi Jiri,
> hid-blink sounds too generic to me, taking into account that this is
> not
> 'generic HID blinking' framework, but rather a specific device driver
> for
> a particular device.
>
> So something like hid-thingm-blink sounds more reasonable to me.
Ok, I'll name the file hid-thingm-blink1.c instead.
Should I keep the Kconfig macro CONFIG_BLINK1 or CONFIG_THINGM_BLINK1
sounds better?
> Linux Kernel is being shipped under GPL v2, without "or any later"
> clause
> added. So I am afraid I can't merge the code with this license.
No problem, I'll change the clause.
Thanks,
Vivien
next prev parent reply other threads:[~2013-01-21 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 19:31 [PATCH] HID: add ThingM blink(1) USB LED support Vivien Didelot
2013-01-21 16:37 ` Jiri Kosina
2013-01-21 17:14 ` Vivien Didelot [this message]
2013-01-21 18:36 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329559360.389477.1358788441066.JavaMail.root@mail.savoirfairelinux.com \
--to=vivien.didelot@savoirfairelinux.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).