From: Chao Xie <chao.xie@marvell.com>
To: linux-input@vger.kernel.org, eric.y.miao@gmail.com,
haojian.zhuang@marvell.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] Input: pxa27x_keypad bug fix for direct_key_mask
Date: Wed, 28 Mar 2012 13:08:42 +0800 [thread overview]
Message-ID: <1332911324-9840-2-git-send-email-chao.xie@marvell.com> (raw)
In-Reply-To: <1332911324-9840-1-git-send-email-chao.xie@marvell.com>
When direcct_key_num is 0, the mask should be 0.
When direcct_key_num is 1, the mask should be 0b1.
Signed-off-by: Chao Xie <chao.xie@marvell.com>
---
drivers/input/keyboard/pxa27x_keypad.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
index 1c5752f..f9a76d4 100644
--- a/drivers/input/keyboard/pxa27x_keypad.c
+++ b/drivers/input/keyboard/pxa27x_keypad.c
@@ -383,7 +383,7 @@ static void pxa27x_keypad_config(struct pxa27x_keypad *keypad)
if (pdata->direct_key_num > direct_key_num)
direct_key_num = pdata->direct_key_num;
- keypad->direct_key_mask = ((2 << direct_key_num) - 1) & ~mask;
+ keypad->direct_key_mask = ((1 << direct_key_num) - 1) & ~mask;
/* enable direct key */
if (direct_key_num)
--
1.7.0.4
next prev parent reply other threads:[~2012-03-28 4:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 5:08 [PATCH 1/4] Input: pxa27x_keypad keep clock on as wakeup source Chao Xie
2012-03-28 5:08 ` Chao Xie [this message]
2012-03-28 5:08 ` [PATCH 3/4] Input: pxa27x_keypad direct key may be low active Chao Xie
2012-03-28 5:08 ` [PATCH 4/4] Input: pxa27x_keypad add choice to set direct_key_mask Chao Xie
2012-03-28 18:04 ` Sergei Shtylyov
2012-03-29 9:15 ` Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332911324-9840-2-git-send-email-chao.xie@marvell.com \
--to=chao.xie@marvell.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).