linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: avatar@sentelic.com
Cc: os@ohmu.fl, dtor@mail.ru, linux-input@vger.kernel.org,
	Matthew Garrett <mjg@redhat.com>
Subject: [PATCH] input: Force Sentelic reconnect when mode setting has failed
Date: Sat, 19 May 2012 18:56:32 -0400	[thread overview]
Message-ID: <1337468192-16337-1-git-send-email-mjg@redhat.com> (raw)

The Sentelic touchpad in an Asus UX-21 failed to work since the native
driver was merged. Examination showed that the FSP_REG_SWC1 register had
reverted back to 0x80 and so the pad was sending normal packets despite
the driver expecting absolute ones.

I haven't been able to identify what causes this - dumping the register
state after ps2 setup shows it set correctly. The easiest workaround seems
to be to force a reconnect when an unexpected packet type is received.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
 drivers/input/mouse/sentelic.c |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/input/mouse/sentelic.c b/drivers/input/mouse/sentelic.c
index 661a0ca..aaabf94 100644
--- a/drivers/input/mouse/sentelic.c
+++ b/drivers/input/mouse/sentelic.c
@@ -687,7 +687,7 @@ static psmouse_ret_t fsp_process_byte(struct psmouse *psmouse)
 	unsigned char *packet = psmouse->packet;
 	unsigned char button_status = 0, lscroll = 0, rscroll = 0;
 	unsigned short abs_x, abs_y, fgrs = 0;
-	int rel_x, rel_y;
+	int rel_x, rel_y, packet_type;
 
 	if (psmouse->pktcnt < 4)
 		return PSMOUSE_GOOD_DATA;
@@ -698,7 +698,17 @@ static psmouse_ret_t fsp_process_byte(struct psmouse *psmouse)
 
 	fsp_packet_debug(psmouse, packet);
 
-	switch (psmouse->packet[0] >> FSP_PKT_TYPE_SHIFT) {
+	packet_type = psmouse->packet[0] >> FSP_PKT_TYPE_SHIFT;
+
+	if (ad->ver >= FSP_VER_STL3888_C0 && packet_type != FSP_PKT_TYPE_ABS) {
+		psmouse_warn(psmouse,
+			     "Incorrect packet type %x, reconnecting\n",
+			     packet_type);
+		serio_reconnect(psmouse->ps2dev.serio);
+		return PSMOUSE_FULL_PACKET;
+	}
+
+	switch (packet_type) {
 	case FSP_PKT_TYPE_ABS:
 		abs_x = GET_ABS_X(packet);
 		abs_y = GET_ABS_Y(packet);
-- 
1.7.9.5


             reply	other threads:[~2012-05-19 22:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-19 22:56 Matthew Garrett [this message]
2012-05-21 15:22 ` [PATCH] input: Force Sentelic reconnect when mode setting has failed Tai-hwa Liang
2012-05-21 15:28   ` Matthew Garrett
2012-05-22  3:42     ` Tai-hwa Liang
2012-05-22 20:28       ` Matthew Garrett
2012-05-23 17:22         ` Tai-hwa Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337468192-16337-1-git-send-email-mjg@redhat.com \
    --to=mjg@redhat.com \
    --cc=avatar@sentelic.com \
    --cc=dtor@mail.ru \
    --cc=linux-input@vger.kernel.org \
    --cc=os@ohmu.fl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).