From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: linux-input@vger.kernel.org
Cc: David Herrmann <dh.herrmann@googlemail.com>,
Vojtech Pavlik <vojtech@ucw.cz>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [RFC][PATCH 2/2] HID: wiimote: report keys in Accelerometer too
Date: Mon, 4 Jun 2012 21:19:13 +0200 [thread overview]
Message-ID: <1338837553-10756-3-git-send-email-giuseppe.bilotta@gmail.com> (raw)
In-Reply-To: <1338837553-10756-1-git-send-email-giuseppe.bilotta@gmail.com>
The main input device registered by the wiimote driver gets classified
as a gamepad because it reports the presence of a BTN_A button. This
results in the detection of a joystick device with 7 buttons and no axes
(thus unusable) when a Wii Remote is connected.
By letting the Accelerometer input device also report buttons, we get it
to be recognized as a 7-buttons, 3-axes gamepad, that can be used on
games with no direct Wii Remote support through the joydev interface.
This approach is currently not perfect: button presses gets reported on
two devices (Remote and Accelerometer), and the main device is still
classified as a gamepad due to the mapping.
Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
drivers/hid/hid-wiimote-core.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c
index ece9c28..2177dbe 100644
--- a/drivers/hid/hid-wiimote-core.c
+++ b/drivers/hid/hid-wiimote-core.c
@@ -741,6 +741,7 @@ static void handler_accel(struct wiimote_data *wdata, const __u8 *payload)
input_report_abs(wdata->accel, ABS_RX, x - 0x200);
input_report_abs(wdata->accel, ABS_RY, y - 0x200);
input_report_abs(wdata->accel, ABS_RZ, z - 0x200);
+ report_keys(wdata->accel, wiiproto_keymap, payload);
input_sync(wdata->accel);
}
@@ -1096,6 +1097,11 @@ static struct wiimote_data *wiimote_create(struct hid_device *hdev)
input_set_abs_params(wdata->accel, ABS_RY, -500, 500, 2, 4);
input_set_abs_params(wdata->accel, ABS_RZ, -500, 500, 2, 4);
+ set_bit(EV_KEY, wdata->accel->evbit);
+ for (i = 0; i < WIIPROTO_KEY_COUNT; ++i)
+ set_bit(wiiproto_keymap[i], wdata->accel->keybit);
+
+
wdata->ir = input_allocate_device();
if (!wdata->ir)
goto err_ir;
--
1.7.10.rc3.204.g95589
prev parent reply other threads:[~2012-06-04 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 19:19 [RFC][PATCH 0/2] HID: wiimote: proper joystick device support Giuseppe Bilotta
2012-06-04 19:19 ` [RFC][PATCH 1/2] HID: wiimote: refactor key reporting Giuseppe Bilotta
2012-06-04 19:19 ` Giuseppe Bilotta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338837553-10756-3-git-send-email-giuseppe.bilotta@gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=vojtech@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).