linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Kurtz <djkurtz@chromium.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Henrik Rydberg <rydberg@euromail.se>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Nick Dyer <nick.dyer@itdev.co.uk>,
	linux-input@vger.kernel.org
Cc: Iiro Valkonen <iiro.valkonen@atmel.com>,
	Benson Leung <bleung@chromium.org>,
	Yufeng Shen <miletus@chromium.org>,
	Olof Johansson <olofj@chromium.org>,
	linux-kernel@vger.kernel.org, Daniel Kurtz <djkurtz@chromium.org>
Subject: [PATCH 20/22 v4] Input: atmel_mxt_ts - use T9 reportid range to init number of mt slots
Date: Mon, 18 Jun 2012 12:08:40 +0800	[thread overview]
Message-ID: <1339992522-22073-21-git-send-email-djkurtz@chromium.org> (raw)
In-Reply-To: <1339992522-22073-1-git-send-email-djkurtz@chromium.org>

Atmel mxt devices can report one finger for each T9 reportid.
Therefore, this range can be used to report the max number of MT-B slots
to userspace instead of assuming a fixed 10.

Note that mxt_initialized() must complete early, since the input_dev
properties now depend on values in the object table.

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
---
 drivers/input/touchscreen/atmel_mxt_ts.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index f5ca237..460c10f 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -212,8 +212,6 @@
 /* Touchscreen absolute values */
 #define MXT_MAX_AREA		0xff
 
-#define MXT_MAX_FINGER		10
-
 struct mxt_info {
 	u8 family_id;
 	u8 variant_id;
@@ -1056,6 +1054,7 @@ static int __devinit mxt_probe(struct i2c_client *client,
 	struct mxt_data *data;
 	struct input_dev *input_dev;
 	int error;
+	unsigned int num_mt_slots;
 
 	if (!pdata)
 		return -EINVAL;
@@ -1082,6 +1081,10 @@ static int __devinit mxt_probe(struct i2c_client *client,
 
 	mxt_calc_resolution(data);
 
+	error = mxt_initialize(data);
+	if (error)
+		goto err_free_object;
+
 	__set_bit(EV_ABS, input_dev->evbit);
 	__set_bit(EV_KEY, input_dev->evbit);
 	__set_bit(BTN_TOUCH, input_dev->keybit);
@@ -1095,9 +1098,10 @@ static int __devinit mxt_probe(struct i2c_client *client,
 			     0, 255, 0, 0);
 
 	/* For multi touch */
-	error = input_mt_init_slots(input_dev, MXT_MAX_FINGER);
+	num_mt_slots = data->T9_reportid_max - data->T9_reportid_min + 1;
+	error = input_mt_init_slots(input_dev, num_mt_slots);
 	if (error)
-		goto err_free_mem;
+		goto err_free_object;
 	input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR,
 			     0, MXT_MAX_AREA, 0, 0);
 	input_set_abs_params(input_dev, ABS_MT_POSITION_X,
@@ -1110,10 +1114,6 @@ static int __devinit mxt_probe(struct i2c_client *client,
 	input_set_drvdata(input_dev, data);
 	i2c_set_clientdata(client, data);
 
-	error = mxt_initialize(data);
-	if (error)
-		goto err_free_object;
-
 	error = request_threaded_irq(client->irq, NULL, mxt_interrupt,
 			pdata->irqflags, client->name, data);
 	if (error) {
-- 
1.7.7.3


  parent reply	other threads:[~2012-06-18  4:08 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18  4:08 [PATCH 00/22 v4] cleanup atmel_mxt_ts Daniel Kurtz
2012-06-18  4:08 ` [PATCH 01/22 v4] Input: atmel_mxt_ts - set phys to i2c client adapter name Daniel Kurtz
2012-06-21  8:41   ` Dmitry Torokhov
2012-06-25  8:15     ` Henrik Rydberg
2012-06-25  9:58       ` Daniel Kurtz
2012-06-26  1:27         ` Dmitry Torokhov
2012-06-27  0:42           ` Benson Leung
2012-06-18  4:08 ` [PATCH 02/22 v4] Input: atmel_mxt_ts - use client name for irq Daniel Kurtz
2012-06-18  4:08 ` [PATCH 03/22 v4] Input: atmel_mxt_ts - detect OOM when creating mt slots Daniel Kurtz
2012-06-18  4:08 ` [PATCH 04/22 v4] Input: atmel_mxt_ts - warn if sysfs could not be created Daniel Kurtz
2012-06-18  4:08 ` [PATCH 05/22 v4] Input: atmel_mxt_ts - don't read T5 when dumping objects Daniel Kurtz
2012-06-18  4:08 ` [PATCH 06/22 v4] Input: atmel_mxt_ts - use scnprintf for object sysfs entry Daniel Kurtz
2012-06-18  4:08 ` [PATCH 07/22 v4] Input: atmel_mxt_ts - optimize reading objects in " Daniel Kurtz
2012-06-18  4:08 ` [PATCH 08/22 v4] Input: atmel_mxt_ts - print less overhead when dumping objects Daniel Kurtz
2012-06-18  4:08 ` [PATCH 09/22 v4] Input: atmel_mxt_ts - print all instances " Daniel Kurtz
2012-06-18  4:08 ` [PATCH 10/22 v4] Input: atmel_mxt_ts - return errors from i2c layer Daniel Kurtz
2012-06-18  4:08 ` [PATCH 11/22 v4] Input: atmel_mxt_ts - add variable length __mxt_write_reg Daniel Kurtz
2012-06-18  4:08 ` [PATCH 12/22 v4] Input: atmel_mxt_ts - optimize writing of object table entries Daniel Kurtz
2012-06-18  4:08 ` [PATCH 13/22 v4] Input: atmel_mxt_ts - read ID information block in one i2c transaction Daniel Kurtz
2012-06-18  4:08 ` [PATCH 14/22 v4] Input: atmel_mxt_ts - don't re-read matrix after applying pdata Daniel Kurtz
2012-06-18 15:03   ` Nick Dyer
2012-06-18 15:28     ` Daniel Kurtz
2012-06-18 19:50     ` Yufeng Shen
2012-06-19 10:26       ` Nick Dyer
2012-06-19 15:12         ` Yufeng Shen
2012-06-18  4:08 ` [PATCH 15/22 v4] Input: atmel_mxt_ts - update driver ID info logging Daniel Kurtz
2012-06-18  4:08 ` [PATCH 16/22 v4] Input: atmel_mxt_ts - add sysfs entries to read fw and hw version Daniel Kurtz
2012-06-18  4:08 ` [PATCH 17/22 v4] Input: atmel_mxt_ts - simplify event reporting Daniel Kurtz
2012-06-18  4:08 ` [PATCH 18/22 v4] Input: atmel_mxt_ts - add detail to touchevent debug message Daniel Kurtz
2012-06-18  4:08 ` [PATCH 19/22 v4] Input: atmel_mxt_ts - cache T9 reportid range when reading object table Daniel Kurtz
2012-06-18  4:08 ` Daniel Kurtz [this message]
2012-06-18  4:08 ` [PATCH 21/22 v4] Input: atmel_mxt_ts - send all MT-B slots in one input report Daniel Kurtz
2012-06-18  4:08 ` [PATCH 22/22 v4] Input: atmel_mxt_ts - parse T6 reports Daniel Kurtz
2012-06-18 15:09   ` Nick Dyer
2012-06-18 15:29     ` Daniel Kurtz
2012-06-20 17:38 ` [PATCH 00/22 v4] cleanup atmel_mxt_ts Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339992522-22073-21-git-send-email-djkurtz@chromium.org \
    --to=djkurtz@chromium.org \
    --cc=bleung@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=iiro.valkonen@atmel.com \
    --cc=jy0922.shim@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miletus@chromium.org \
    --cc=nick.dyer@itdev.co.uk \
    --cc=olofj@chromium.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).