From: Daniel Kurtz <djkurtz@chromium.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@euromail.se>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Nick Dyer <nick.dyer@itdev.co.uk>,
Yufeng Shen <miletus@chromium.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Olof Johansson <olof@lixom.net>,
Benson Leung <bleung@chromium.org>,
Daniel Kurtz <djkurtz@chromium.org>
Subject: [PATCH 04/23 v6] Input: atmel_mxt_ts - warn if sysfs could not be created
Date: Thu, 28 Jun 2012 21:08:05 +0800 [thread overview]
Message-ID: <1340888904-15620-5-git-send-email-djkurtz@chromium.org> (raw)
In-Reply-To: <1340888904-15620-1-git-send-email-djkurtz@chromium.org>
If sysfs entry creation fails, the driver is still usable, so don't
just abort probe. Just warn and continue.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
---
drivers/input/touchscreen/atmel_mxt_ts.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 926209c..c72f595 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -1172,13 +1172,10 @@ static int __devinit mxt_probe(struct i2c_client *client,
error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group);
if (error)
- goto err_unregister_device;
+ dev_warn(&client->dev, "error creating sysfs entries.\n");
return 0;
-err_unregister_device:
- input_unregister_device(input_dev);
- input_dev = NULL;
err_free_irq:
free_irq(client->irq, data);
err_free_object:
--
1.7.7.3
next prev parent reply other threads:[~2012-06-28 13:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 13:08 [PATCH 00/23 v6] cleanup atmel_mxt_ts Daniel Kurtz
2012-06-28 13:08 ` [PATCH 01/23 v6] Input: atmel_mxt_ts - derive phys from i2c client adapter Daniel Kurtz
2012-06-28 13:08 ` [PATCH 02/23 v6] Input: atmel_mxt_ts - use client name for irq Daniel Kurtz
2012-06-28 13:08 ` [PATCH 03/23 v6] Input: atmel_mxt_ts - detect OOM when creating mt slots Daniel Kurtz
2012-06-28 13:08 ` Daniel Kurtz [this message]
2012-07-05 17:22 ` [PATCH 04/23 v6] Input: atmel_mxt_ts - warn if sysfs could not be created Dmitry Torokhov
2012-07-05 19:15 ` Henrik Rydberg
2012-07-16 2:34 ` Daniel Kurtz
2012-06-28 13:08 ` [PATCH 05/23 v6] Input: atmel_mxt_ts - don't read T5 when dumping objects Daniel Kurtz
2012-06-28 13:08 ` [PATCH 06/23 v6] Input: atmel_mxt_ts - use scnprintf for object sysfs entry Daniel Kurtz
2012-06-28 13:08 ` [PATCH 07/23 v6] Input: atmel_mxt_ts - optimize reading objects in " Daniel Kurtz
2012-06-28 13:08 ` [PATCH 08/23 v6] Input: atmel_mxt_ts - print less overhead when dumping objects Daniel Kurtz
2012-06-28 13:08 ` [PATCH 09/23 v6] Input: atmel_mxt_ts - print all instances " Daniel Kurtz
2012-06-28 13:08 ` [PATCH 10/23 v6] Input: atmel_mxt_ts - return errors from i2c layer Daniel Kurtz
2012-06-28 13:08 ` [PATCH 11/23 v6] Input: atmel_mxt_ts - add variable length __mxt_write_reg Daniel Kurtz
2012-06-28 13:08 ` [PATCH 12/23 v6] Input: atmel_mxt_ts - optimize writing of object table entries Daniel Kurtz
2012-06-28 13:08 ` [PATCH 13/23 v6] Input: atmel_mxt_ts - read ID information block in one i2c transaction Daniel Kurtz
2012-06-28 13:08 ` [PATCH 14/23 v6] Input: atmel_mxt_ts - update driver ID info logging Daniel Kurtz
2012-06-28 13:08 ` [PATCH 15/23 v6] Input: atmel_mxt_ts - add sysfs entries to read fw and hw version Daniel Kurtz
2012-06-28 13:08 ` [PATCH 16/23 v6] Input: atmel_mxt_ts - simplify event reporting Daniel Kurtz
2012-06-28 13:08 ` [PATCH 17/23 v6] Input: atmel_mxt_ts - add detail to touchevent debug message Daniel Kurtz
2012-06-28 13:08 ` [PATCH 18/23 v6] Input: atmel_mxt_ts - refactor when and how object table is freed Daniel Kurtz
2012-06-28 13:08 ` [PATCH 19/23 v6] Input: atmel_mxt_ts - cache T9 reportid range when reading object table Daniel Kurtz
2012-06-28 13:08 ` [PATCH 20/23 v6] Input: atmel_mxt_ts - refactor reportid checking in mxt_interrupt Daniel Kurtz
2012-06-28 13:08 ` [PATCH 21/23 v6] Input: atmel_mxt_ts - use T9 reportid range to init number of mt slots Daniel Kurtz
2012-06-28 13:08 ` [PATCH 22/23 v6] Input: atmel_mxt_ts - send all MT-B slots in one input report Daniel Kurtz
2012-06-28 13:08 ` [PATCH 23/23 v6] Input: atmel_mxt_ts - parse T6 reports Daniel Kurtz
2012-06-29 14:23 ` [PATCH 00/23 v6] cleanup atmel_mxt_ts Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340888904-15620-5-git-send-email-djkurtz@chromium.org \
--to=djkurtz@chromium.org \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=nick.dyer@itdev.co.uk \
--cc=olof@lixom.net \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).