* [PATCH] Input: keyboard: omap-keypad: Fixed coding style issue.
@ 2012-08-24 0:20 Josh
2012-09-05 6:11 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Josh @ 2012-08-24 0:20 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, Josh
Fixed spacing error on if statements and fixed tab error.
Signed-off-by: Josh <joshua.taylor0@gmail.com>
---
drivers/input/keyboard/omap-keypad.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c
index a0222db..b03c5b9 100644
--- a/drivers/input/keyboard/omap-keypad.c
+++ b/drivers/input/keyboard/omap-keypad.c
@@ -214,7 +214,7 @@ static void omap_kp_tasklet(unsigned long data)
memcpy(keypad_state, new_state, sizeof(keypad_state));
if (key_down) {
- int delay = HZ / 20;
+ int delay = HZ / 20;
/* some key is pressed - keep irq disabled and use timer
* to poll the keypad */
if (spurious)
@@ -413,7 +413,7 @@ static int __devinit omap_kp_probe(struct platform_device *pdev)
}
return 0;
err5:
- for (i = irq_idx - 1; i >=0; i--)
+ for (i = irq_idx - 1; i >= 0; i--)
free_irq(row_gpios[i], omap_kp);
err4:
input_unregister_device(omap_kp->input);
@@ -421,10 +421,10 @@ err4:
err3:
device_remove_file(&pdev->dev, &dev_attr_enable);
err2:
- for (i = row_idx - 1; i >=0; i--)
+ for (i = row_idx - 1; i >= 0; i--)
gpio_free(row_gpios[i]);
err1:
- for (i = col_idx - 1; i >=0; i--)
+ for (i = col_idx - 1; i >= 0; i--)
gpio_free(col_gpios[i]);
kfree(omap_kp);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: keyboard: omap-keypad: Fixed coding style issue.
2012-08-24 0:20 [PATCH] Input: keyboard: omap-keypad: Fixed coding style issue Josh
@ 2012-09-05 6:11 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2012-09-05 6:11 UTC (permalink / raw)
To: Josh; +Cc: linux-input
On Thu, Aug 23, 2012 at 08:20:21PM -0400, Josh wrote:
> Fixed spacing error on if statements and fixed tab error.
> Signed-off-by: Josh <joshua.taylor0@gmail.com>
Applied, thank you Josh.
> ---
> drivers/input/keyboard/omap-keypad.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c
> index a0222db..b03c5b9 100644
> --- a/drivers/input/keyboard/omap-keypad.c
> +++ b/drivers/input/keyboard/omap-keypad.c
> @@ -214,7 +214,7 @@ static void omap_kp_tasklet(unsigned long data)
> memcpy(keypad_state, new_state, sizeof(keypad_state));
>
> if (key_down) {
> - int delay = HZ / 20;
> + int delay = HZ / 20;
> /* some key is pressed - keep irq disabled and use timer
> * to poll the keypad */
> if (spurious)
> @@ -413,7 +413,7 @@ static int __devinit omap_kp_probe(struct platform_device *pdev)
> }
> return 0;
> err5:
> - for (i = irq_idx - 1; i >=0; i--)
> + for (i = irq_idx - 1; i >= 0; i--)
> free_irq(row_gpios[i], omap_kp);
> err4:
> input_unregister_device(omap_kp->input);
> @@ -421,10 +421,10 @@ err4:
> err3:
> device_remove_file(&pdev->dev, &dev_attr_enable);
> err2:
> - for (i = row_idx - 1; i >=0; i--)
> + for (i = row_idx - 1; i >= 0; i--)
> gpio_free(row_gpios[i]);
> err1:
> - for (i = col_idx - 1; i >=0; i--)
> + for (i = col_idx - 1; i >= 0; i--)
> gpio_free(col_gpios[i]);
>
> kfree(omap_kp);
> --
> 1.7.9.5
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-05 6:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-24 0:20 [PATCH] Input: keyboard: omap-keypad: Fixed coding style issue Josh
2012-09-05 6:11 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).