linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: linux-input@vger.kernel.org
Cc: Stefano Babic <sbabic@denx.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Simon Budig <simon.budig@kernelconcepts.de>,
	Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH] input: wrong irq requested in edt-ft5x06.c
Date: Wed, 19 Sep 2012 16:53:54 +0200	[thread overview]
Message-ID: <1348066434-2168-1-git-send-email-sbabic@denx.de> (raw)

The probe function checks for integrity the pdata->irq_pin,
but then does not request this line for interrupt.
For this reason, no interrupts are generated.

Tested on a AM3517 board with EP0700M06

Signed-off-by: Stefano Babic <sbabic@denx.de>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Simon Budig <simon.budig@kernelconcepts.de>
CC: Guenter Roeck <linux@roeck-us.net>
---
 drivers/input/touchscreen/edt-ft5x06.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index b06a5e3..9608281 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -788,7 +788,8 @@ static int __devinit edt_ft5x06_ts_probe(struct i2c_client *client,
 	input_set_drvdata(input, tsdata);
 	i2c_set_clientdata(client, tsdata);
 
-	error = request_threaded_irq(client->irq, NULL, edt_ft5x06_ts_isr,
+	error = request_threaded_irq(gpio_to_irq(pdata->irq_pin), NULL,
+				     edt_ft5x06_ts_isr,
 				     IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 				     client->name, tsdata);
 	if (error) {
-- 
1.7.9.5


             reply	other threads:[~2012-09-19 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 14:53 Stefano Babic [this message]
2012-09-19 16:58 ` [PATCH] input: wrong irq requested in edt-ft5x06.c Dmitry Torokhov
2012-09-20  8:18   ` Stefano Babic
2012-09-20  8:31     ` Simon Budig
2012-09-20  8:56       ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348066434-2168-1-git-send-email-sbabic@denx.de \
    --to=sbabic@denx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=simon.budig@kernelconcepts.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).