* [PATCH] atmel_mxt: simplify mxt_dump_message
@ 2012-09-26 11:05 Andy Shevchenko
2012-09-26 14:18 ` Daniel Kurtz
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2012-09-26 11:05 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: Andy Shevchenko
This patch applies %*ph to print small buffer and marks function as inline.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/input/touchscreen/atmel_mxt_ts.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index e92615d..211bfb4 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -317,13 +317,11 @@ static bool mxt_object_writable(unsigned int type)
}
}
-static void mxt_dump_message(struct device *dev,
- struct mxt_message *message)
+static inline void mxt_dump_message(struct device *dev,
+ struct mxt_message *message)
{
- dev_dbg(dev, "reportid: %u\tmessage: %02x %02x %02x %02x %02x %02x %02x\n",
- message->reportid, message->message[0], message->message[1],
- message->message[2], message->message[3], message->message[4],
- message->message[5], message->message[6]);
+ dev_dbg(dev, "reportid: %u\tmessage: %*ph\n",
+ message->reportid, 7, message->message);
}
static int mxt_check_bootloader(struct i2c_client *client,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] atmel_mxt: simplify mxt_dump_message
2012-09-26 11:05 [PATCH] atmel_mxt: simplify mxt_dump_message Andy Shevchenko
@ 2012-09-26 14:18 ` Daniel Kurtz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kurtz @ 2012-09-26 14:18 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Dmitry Torokhov, linux-input
On Wed, Sep 26, 2012 at 7:05 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> This patch applies %*ph to print small buffer and marks function as inline.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
>
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index e92615d..211bfb4 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -317,13 +317,11 @@ static bool mxt_object_writable(unsigned int type)
> }
> }
>
> -static void mxt_dump_message(struct device *dev,
> - struct mxt_message *message)
> +static inline void mxt_dump_message(struct device *dev,
> + struct mxt_message *message)
> {
> - dev_dbg(dev, "reportid: %u\tmessage: %02x %02x %02x %02x %02x %02x %02x\n",
> - message->reportid, message->message[0], message->message[1],
> - message->message[2], message->message[3], message->message[4],
> - message->message[5], message->message[6]);
> + dev_dbg(dev, "reportid: %u\tmessage: %*ph\n",
> + message->reportid, 7, message->message);
> }
>
> static int mxt_check_bootloader(struct i2c_client *client,
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-26 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-26 11:05 [PATCH] atmel_mxt: simplify mxt_dump_message Andy Shevchenko
2012-09-26 14:18 ` Daniel Kurtz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).