From: Joe Perches <joe@perches.com>
To: Mischa Jonker <mischa.jonker@synopsys.com>
Cc: dmitry.torokhov@gmail.com, m.d.s.x.jonker@gmail.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
arc-linux-dev@synopsys.com
Subject: Re: [PATCH v3 1/1] Input: serio - Add ARC PS/2 driver
Date: Thu, 18 Oct 2012 02:01:56 -0700 [thread overview]
Message-ID: <1350550916.3072.61.camel@joe-AO722> (raw)
In-Reply-To: <1350549367-11098-2-git-send-email-mischa.jonker@synopsys.com>
On Thu, 2012-10-18 at 10:36 +0200, Mischa Jonker wrote:
> This adds support for the PS/2 block that is used in various ARC FPGA
> platforms.
[]
> diff --git a/drivers/input/serio/arc_ps2.c b/drivers/input/serio/arc_ps2.c
[]
> +static void arc_ps2_check_rx(struct arc_ps2_data *arc_ps2,
> + struct arc_ps2_port *port)
> +{
> + unsigned flag, status;
> + unsigned char data;
> +
> + while (1) {
infinite loop with bad hardware?
Perhaps a jiffies timeout?
next prev parent reply other threads:[~2012-10-18 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 8:36 [PATCH v3 0/1] Input: serio - Add ARC PS/2 driver Mischa Jonker
2012-10-18 8:36 ` [PATCH v3 1/1] " Mischa Jonker
2012-10-18 9:01 ` Joe Perches [this message]
2012-10-18 9:05 ` Mischa Jonker
2012-10-18 9:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350550916.3072.61.camel@joe-AO722 \
--to=joe@perches.com \
--cc=arc-linux-dev@synopsys.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.d.s.x.jonker@gmail.com \
--cc=mischa.jonker@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox