linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: select INPUT_MATRIXKMAP for lpc32xx-keys
@ 2012-10-27  7:40 Roland Stigge
  2012-10-31  5:55 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Roland Stigge @ 2012-10-27  7:40 UTC (permalink / raw)
  To: dmitry.torokhov, linux-input, linux-kernel, grant.likely; +Cc: Roland Stigge

This patch adds a "select" dependency of KEYBOARD_LPC32XX on INPUT_MATRIXKMAP,
as the other drivers are doing in this regard. This fixes the following compile
error if KEYBOARD_LPC32XX is enabled but INPUT_MATRIXKMAP is not:

drivers/input/keyboard/lpc32xx-keys.c:230: undefined reference to
`matrix_keypad_build_keymap'

Signed-off-by: Roland Stigge <stigge@antcom.de>

---
 drivers/input/keyboard/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.orig/drivers/input/keyboard/Kconfig
+++ linux-2.6/drivers/input/keyboard/Kconfig
@@ -335,6 +335,7 @@ config KEYBOARD_LOCOMO
 config KEYBOARD_LPC32XX
 	tristate "LPC32XX matrix key scanner support"
 	depends on ARCH_LPC32XX && OF
+	select INPUT_MATRIXKMAP
 	help
 	  Say Y here if you want to use NXP LPC32XX SoC key scanner interface,
 	  connected to a key matrix.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Input: select INPUT_MATRIXKMAP for lpc32xx-keys
  2012-10-27  7:40 [PATCH] Input: select INPUT_MATRIXKMAP for lpc32xx-keys Roland Stigge
@ 2012-10-31  5:55 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2012-10-31  5:55 UTC (permalink / raw)
  To: Roland Stigge; +Cc: linux-input, linux-kernel, grant.likely

On Sat, Oct 27, 2012 at 09:40:48AM +0200, Roland Stigge wrote:
> This patch adds a "select" dependency of KEYBOARD_LPC32XX on INPUT_MATRIXKMAP,
> as the other drivers are doing in this regard. This fixes the following compile
> error if KEYBOARD_LPC32XX is enabled but INPUT_MATRIXKMAP is not:
> 
> drivers/input/keyboard/lpc32xx-keys.c:230: undefined reference to
> `matrix_keypad_build_keymap'
> 
> Signed-off-by: Roland Stigge <stigge@antcom.de>

Applied, thank you Roland.

> 
> ---
>  drivers/input/keyboard/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-2.6.orig/drivers/input/keyboard/Kconfig
> +++ linux-2.6/drivers/input/keyboard/Kconfig
> @@ -335,6 +335,7 @@ config KEYBOARD_LOCOMO
>  config KEYBOARD_LPC32XX
>  	tristate "LPC32XX matrix key scanner support"
>  	depends on ARCH_LPC32XX && OF
> +	select INPUT_MATRIXKMAP
>  	help
>  	  Say Y here if you want to use NXP LPC32XX SoC key scanner interface,
>  	  connected to a key matrix.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-31  5:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-27  7:40 [PATCH] Input: select INPUT_MATRIXKMAP for lpc32xx-keys Roland Stigge
2012-10-31  5:55 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).