From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: "benjamin.tissoires" <benjamin.tissoires@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@euromail.se>,
Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 12/14] HID: hid-multitouch: support for hovering devices
Date: Wed, 14 Nov 2012 16:59:24 +0100 [thread overview]
Message-ID: <1352908766-4492-13-git-send-email-benjamin.tissoires@gmail.com> (raw)
In-Reply-To: <1352908766-4492-1-git-send-email-benjamin.tissoires@gmail.com>
Win8 devices supporting hovering must provides InRange HID field.
The information that the finger is here but is not touching the surface
is sent to the user space through ABS_MT_DISTANCE as required by the
multitouch protocol.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
---
drivers/hid/hid-multitouch.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index c5b81a7..5f26b2f 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -53,11 +53,13 @@ MODULE_LICENSE("GPL");
#define MT_QUIRK_SLOT_IS_CONTACTID_MINUS_ONE (1 << 8)
#define MT_QUIRK_NO_AREA (1 << 9)
#define MT_QUIRK_IGNORE_DUPLICATES (1 << 10)
+#define MT_QUIRK_HOVERING (1 << 11)
struct mt_slot {
__s32 x, y, cx, cy, p, w, h;
__s32 contactid; /* the device ContactID assigned to this slot */
bool touch_state; /* is the touch valid? */
+ bool inrange_state; /* is the finger in proximity of the sensor? */
};
struct mt_class {
@@ -392,6 +394,12 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
case HID_UP_DIGITIZER:
switch (usage->hid) {
case HID_DG_INRANGE:
+ if (cls->quirks & MT_QUIRK_HOVERING) {
+ hid_map_usage(hi, usage, bit, max,
+ EV_ABS, ABS_MT_DISTANCE);
+ input_set_abs_params(hi->input,
+ ABS_MT_DISTANCE, 0, 1, 0, 0);
+ }
mt_store_field(usage, td, hi);
td->last_field_index = field->index;
return 1;
@@ -521,9 +529,9 @@ static void mt_complete_slot(struct mt_device *td, struct input_dev *input)
input_mt_slot(input, slotnum);
input_mt_report_slot_state(input, MT_TOOL_FINGER,
- s->touch_state);
- if (s->touch_state) {
- /* this finger is on the screen */
+ s->touch_state || s->inrange_state);
+ if (s->touch_state || s->inrange_state) {
+ /* this finger is in proximity of the sensor */
int wide = (s->w > s->h);
/* divided by two to match visual scale of touch */
int major = max(s->w, s->h) >> 1;
@@ -533,6 +541,8 @@ static void mt_complete_slot(struct mt_device *td, struct input_dev *input)
input_event(input, EV_ABS, ABS_MT_POSITION_Y, s->y);
input_event(input, EV_ABS, ABS_MT_TOOL_X, s->cx);
input_event(input, EV_ABS, ABS_MT_TOOL_Y, s->cy);
+ input_event(input, EV_ABS, ABS_MT_DISTANCE,
+ !s->touch_state);
input_event(input, EV_ABS, ABS_MT_ORIENTATION, wide);
input_event(input, EV_ABS, ABS_MT_PRESSURE, s->p);
input_event(input, EV_ABS, ABS_MT_TOUCH_MAJOR, major);
@@ -565,6 +575,8 @@ static int mt_event(struct hid_device *hid, struct hid_field *field,
case HID_DG_INRANGE:
if (quirks & MT_QUIRK_VALID_IS_INRANGE)
td->curvalid = value;
+ if (quirks & MT_QUIRK_HOVERING)
+ td->curdata.inrange_state = value;
break;
case HID_DG_TIPSWITCH:
if (quirks & MT_QUIRK_NOT_SEEN_MEANS_UP)
--
1.8.0
next prev parent reply other threads:[~2012-11-14 15:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 15:59 [PATCH v4 00/14] Win 8 support for digitizers Benjamin Tissoires
2012-11-14 15:59 ` [PATCH v4 01/14] HID: hid-input: export hidinput_calc_abs_res Benjamin Tissoires
2012-11-14 15:59 ` [PATCH v4 02/14] HID: hid-input: round return value of hidinput_calc_abs_res Benjamin Tissoires
2012-11-14 15:59 ` [PATCH v4 03/14] HID: core: fix unit exponent parsing Benjamin Tissoires
2012-11-14 15:59 ` [PATCH v4 04/14] HID: hid-input: add usage_index in struct hid_usage Benjamin Tissoires
2012-11-14 15:59 ` [PATCH v4 05/14] HID: hid-multitouch: support arrays for the split of the touches in a report Benjamin Tissoires
2012-11-14 15:59 ` [PATCH v4 06/14] HID: hid-multitouch: get maxcontacts also from logical_max value Benjamin Tissoires
2012-11-14 15:59 ` [PATCH v4 07/14] HID: hid-multitouch: support T and C for win8 devices Benjamin Tissoires
2012-11-14 15:59 ` [PATCH v4 08/14] HID: hid-multitouch: move ALWAYS_VALID quirk check Benjamin Tissoires
2012-11-14 15:59 ` [PATCH v4 09/14] Input: introduce EV_MSC Timestamp Benjamin Tissoires
2012-11-14 16:33 ` Dmitry Torokhov
2012-11-15 9:14 ` Jiri Kosina
2012-11-14 17:53 ` Henrik Rydberg
2012-11-14 15:59 ` [PATCH v4 10/14] Input: mt: add input_mt_is_used Benjamin Tissoires
2012-11-14 17:16 ` Henrik Rydberg
2012-11-14 15:59 ` [PATCH v4 11/14] HID: hid-multitouch: add MT_QUIRK_IGNORE_DUPLICATES Benjamin Tissoires
2012-11-14 18:08 ` Henrik Rydberg
2012-11-14 15:59 ` Benjamin Tissoires [this message]
2012-11-14 18:43 ` [PATCH v4 12/14] HID: hid-multitouch: support for hovering devices Henrik Rydberg
2012-11-14 15:59 ` [PATCH v4 13/14] HID: hid-multitouch: fix Win 8 protocol Benjamin Tissoires
2012-11-14 18:47 ` Henrik Rydberg
2012-11-14 15:59 ` [PATCH v4 14/14] HID: hid-multitouch: forwards MSC_TIMESTAMP Benjamin Tissoires
2012-11-14 19:58 ` Henrik Rydberg
2012-11-14 21:27 ` Benjamin Tissoires
2012-11-16 20:09 ` Henrik Rydberg
2012-11-19 14:50 ` Benjamin Tissoires
2012-11-20 20:51 ` Henrik Rydberg
2012-11-20 20:54 ` Henrik Rydberg
2012-11-22 20:12 ` Benjamin Tissoires
2012-11-22 21:03 ` Henrik Rydberg
2012-11-14 20:01 ` [PATCH v4 00/14] Win 8 support for digitizers Henrik Rydberg
2012-11-15 9:33 ` Jiri Kosina
2012-11-15 11:11 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352908766-4492-13-git-send-email-benjamin.tissoires@gmail.com \
--to=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).