From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: [PATCH 4/5] Input: tca8418_keypad - increase severity of failures in probe() Date: Wed, 14 Nov 2012 08:48:07 -0800 Message-ID: <1352911688-5001-4-git-send-email-dmitry.torokhov@gmail.com> References: <1352911688-5001-1-git-send-email-dmitry.torokhov@gmail.com> Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:45862 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423064Ab2KNQsQ (ORCPT ); Wed, 14 Nov 2012 11:48:16 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so488529pbc.19 for ; Wed, 14 Nov 2012 08:48:16 -0800 (PST) In-Reply-To: <1352911688-5001-1-git-send-email-dmitry.torokhov@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Alban Bedel Cc: linux-input@vger.kernel.org Failures to build a keymap, request an IRQ, or register input device are fatal for the driver, therefore the messages should have "error" severity instead of "debug". Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/tca8418_keypad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c index 35340c3..10047eb 100644 --- a/drivers/input/keyboard/tca8418_keypad.c +++ b/drivers/input/keyboard/tca8418_keypad.c @@ -348,7 +348,7 @@ static int __devinit tca8418_keypad_probe(struct i2c_client *client, error = matrix_keypad_build_keymap(keymap_data, NULL, rows, cols, keypad_data->keymap, input); if (error) { - dev_dbg(dev, "Failed to build keymap\n"); + dev_err(dev, "Failed to build keymap\n"); goto fail2; } @@ -367,14 +367,14 @@ static int __devinit tca8418_keypad_probe(struct i2c_client *client, IRQF_ONESHOT, client->name, keypad_data); if (error) { - dev_dbg(dev, "Unable to claim irq %d; error %d\n", + dev_err(dev, "Unable to claim irq %d; error %d\n", client->irq, error); goto fail2; } error = input_register_device(input); if (error) { - dev_dbg(dev, "Unable to register input device, error: %d\n", + dev_err(dev, "Unable to register input device, error: %d\n", error); goto fail3; } -- 1.7.11.7