From: Kamal Mostafa <kamal@canonical.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Henrik Rydberg <rydberg@euromail.se>,
David Solda <dso@cypress.com>, Troy Abercrombia <ta@cypress.com>,
Cypress Semiconductor Corporation <customercare@cypress.com>,
Kyle Fazzari <git@status.e4ward.com>,
Mario Limonciello <mario_limonciello@dell.com>,
Tim Gardner <tim.gardner@canonical.com>,
Herton Krzesinski <herton.krzesinski@canonical.com>,
Dudley Du <dudl@cypress.com>
Subject: Re: [PATCH 2/2] input: Cypress PS/2 Trackpad link into psmouse-base
Date: Tue, 20 Nov 2012 13:28:49 -0800 [thread overview]
Message-ID: <1353446929.28318.43.camel@fourier> (raw)
In-Reply-To: <20121119234801.GB21922@core.coreip.homeip.net>
On Mon, 2012-11-19 at 15:48 -0800, Dmitry Torokhov wrote:
> Hi Kamal,
>
> On Mon, Nov 19, 2012 at 03:30:37PM -0800, Kamal Mostafa wrote:
> > @@ -321,6 +323,13 @@ static irqreturn_t psmouse_interrupt(struct serio *serio,
> > if (psmouse->state <= PSMOUSE_RESYNCING)
> > goto out;
> >
> > + /* For Cypress Trackpad to read some special data more than 6 bytes. */
> > + if (psmouse->state == PSMOUSE_CMD_CYTP) {
> > + psmouse->packet[psmouse->pktcnt++] = data;
> > + wake_up(&psmouse->ps2dev.wait);
> > + goto out;
> > + }
>
> Instead of doing this have you tried extending size of cmdbuf in ps2dev
> structure to 8?
>
Thanks for suggesting this Dmitry. I have now done that (and modified
cypress_ps2.c to set psmouse->state to the common PSMOUSE_CMD_MODE
instead). This makes the psmouse-base linkage entirely clean, I
think...
And it *almost* works! (Multitouch no longer works after suspend now).
Please see the forthcoming [PATCH v2] set, and thanks again for your
help.
-Kamal
prev parent reply other threads:[~2012-11-20 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 23:30 [PATCH 0/2] Cypress PS/2 Trackpad driver Kamal Mostafa
2012-11-19 23:30 ` [PATCH 1/2] input: Cypress PS/2 Trackpad psmouse driver Kamal Mostafa
2012-11-19 23:30 ` [PATCH 2/2] input: Cypress PS/2 Trackpad link into psmouse-base Kamal Mostafa
2012-11-19 23:48 ` Dmitry Torokhov
2012-11-20 21:28 ` Kamal Mostafa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353446929.28318.43.camel@fourier \
--to=kamal@canonical.com \
--cc=customercare@cypress.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dso@cypress.com \
--cc=dudl@cypress.com \
--cc=git@status.e4ward.com \
--cc=herton.krzesinski@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=rydberg@euromail.se \
--cc=ta@cypress.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).