linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kamal Mostafa <kamal@canonical.com>
To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Henrik Rydberg <rydberg@euromail.se>
Cc: David Solda <dso@cypress.com>, Troy Abercrombia <ta@cypress.com>,
	Dudley Du <dudl@cypress.com>,
	Cypress Semiconductor Corporation <customercare@cypress.com>,
	Kamal Mostafa <kamal@canonical.com>,
	Kyle Fazzari <git@status.e4ward.com>,
	Mario Limonciello <mario_limonciello@dell.com>,
	Tim Gardner <tim.gardner@canonical.com>,
	Herton Krzesinski <herton.krzesinski@canonical.com>
Subject: [PATCH v2 0/3] Cypress PS/2 Trackpad driver
Date: Tue, 20 Nov 2012 13:30:07 -0800	[thread overview]
Message-ID: <1353447010-4852-1-git-send-email-kamal@canonical.com> (raw)

This driver, submitted on behalf of Cypress Semiconductor Corporation and
additional contributors, provides support for the Cypress PS/2 Trackpad.

This [PATCH v2] version differs from my first submission[0]:

 - Increases the size the of the cmdbuf[] array in struct ps2dev from
   6 to 8 bytes, per Dmitry Torokhov's suggestion.  ** This change has
   not been tested with respect to any other touchpads.  Is it safe? **

 - Removes the special Cypress handling from psmouse-base.c

And it *almost* works properly... Cypress PS/2 Trackpad is recognized and
works fine on boot, but after a suspend-resume multitouch features no longer
work (one and two finger tap works, but three does not).  Restarting X does
fix it, until the next suspend.  The previous version of the driver[0] does
not exhibit that problem.

Help identifying and fixing the suspend-resume issue will be much
appreciated.

 -Kamal Mostafa <kamal@canonical.com>

[0] http://www.spinics.net/lists/linux-input/msg23690.html


Cypress Semiconductor Corporation (2):
  input: Cypress PS/2 Trackpad psmouse driver
  input: Cypress PS/2 Trackpad link into psmouse-base

Kamal Mostafa (1):
  input: increase struct ps2dev cmdbuf[] to 8 bytes

 drivers/input/mouse/Kconfig        |   10 +
 drivers/input/mouse/Makefile       |    1 +
 drivers/input/mouse/cypress_ps2.c  |  956 ++++++++++++++++++++++++++++++++++++
 drivers/input/mouse/cypress_ps2.h  |  220 +++++++++
 drivers/input/mouse/psmouse-base.c |   32 ++
 drivers/input/mouse/psmouse.h      |    1 +
 include/linux/libps2.h             |    2 +-
 7 files changed, 1221 insertions(+), 1 deletion(-)
 create mode 100644 drivers/input/mouse/cypress_ps2.c
 create mode 100644 drivers/input/mouse/cypress_ps2.h

-- 
1.7.10.4

             reply	other threads:[~2012-11-20 21:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 21:30 Kamal Mostafa [this message]
2012-11-20 21:30 ` [PATCH v2 1/3] input: increase struct ps2dev cmdbuf[] to 8 bytes Kamal Mostafa
2012-11-20 21:30 ` [PATCH v2 2/3] input: Cypress PS/2 Trackpad psmouse driver Kamal Mostafa
2012-11-21 19:20   ` Henrik Rydberg
2012-11-29 21:55     ` Kamal Mostafa
2012-11-20 21:30 ` [PATCH v2 3/3] input: Cypress PS/2 Trackpad link into psmouse-base Kamal Mostafa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353447010-4852-1-git-send-email-kamal@canonical.com \
    --to=kamal@canonical.com \
    --cc=customercare@cypress.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dso@cypress.com \
    --cc=dudl@cypress.com \
    --cc=git@status.e4ward.com \
    --cc=herton.krzesinski@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=rydberg@euromail.se \
    --cc=ta@cypress.com \
    --cc=tim.gardner@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).