From: Kamal Mostafa <kamal@canonical.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Henrik Rydberg <rydberg@euromail.se>,
Dudley Du <dudl@cypress.com>, David Solda <dso@cypress.com>,
Troy Abercrombia <ta@cypress.com>,
Kyle Fazzari <git@status.e4ward.com>,
Mario Limonciello <mario_limonciello@dell.com>,
Tim Gardner <tim.gardner@canonical.com>,
Herton Krzesinski <herton.krzesinski@canonical.com>
Subject: Re: [PATCH v5 2/3] input: Cypress PS/2 Trackpad psmouse driver
Date: Thu, 06 Dec 2012 18:09:04 -0800 [thread overview]
Message-ID: <1354846144.2795.76.camel@fourier> (raw)
In-Reply-To: <20121206080850.GC25921@core.coreip.homeip.net>
On Thu, 2012-12-06 at 00:08 -0800, Dmitry Torokhov wrote:
> [...]
Hi Dmitry-
Thanks again for your review. The forthcoming PATCH v6 addresses all of
your requests, except for:
> > + __set_bit(INPUT_PROP_BUTTONPAD, input->propbit);
>
> I do not think it should be marked INPUT_PROP_BUTTONPAD if it has
> physical buttons...
This device (my particular Cypress Trackpad unit anyway) does not have
physical buttons. The pad is clickable; I think it is a standard
"buttonpad" device.
And just FYI, this issue has been addressed but to answer your question:
> > +
> > + if (cytp->mode & CYTP_BIT_ABS_MASK) {
>
> It can't be anything else, can it?
It can: in the case when the mode hasn't been set at all yet (during
detect and reconnect). I cleaned up the logic of this routine
(cypress_validate_byte) and added explanatory comments.
-Kamal
next prev parent reply other threads:[~2012-12-07 2:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 0:16 [PATCH v5 0/3] Cypress PS/2 Trackpad driver Kamal Mostafa
2012-12-06 0:16 ` [PATCH v5 1/3] input: increase struct ps2dev cmdbuf[] to 8 bytes Kamal Mostafa
2012-12-06 7:51 ` Dmitry Torokhov
2012-12-06 0:16 ` [PATCH v5 2/3] input: Cypress PS/2 Trackpad psmouse driver Kamal Mostafa
2012-12-06 8:08 ` Dmitry Torokhov
2012-12-07 2:09 ` Kamal Mostafa [this message]
2012-12-06 0:16 ` [PATCH v5 3/3] input: Cypress PS/2 Trackpad link into psmouse-base Kamal Mostafa
2012-12-06 7:52 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354846144.2795.76.camel@fourier \
--to=kamal@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dso@cypress.com \
--cc=dudl@cypress.com \
--cc=git@status.e4ward.com \
--cc=herton.krzesinski@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=rydberg@euromail.se \
--cc=ta@cypress.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).