From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-input@vger.kernel.org
Cc: Michael Hennerich <michael.hennerich@analog.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
device-drivers-devel@blackfin.uclinux.org,
Wolfram Sang <w.sang@pengutronix.de>
Subject: [PATCH 2/4] input: adxl34x: don't set THRESH_TAP twice
Date: Thu, 20 Dec 2012 14:51:09 +0100 [thread overview]
Message-ID: <1356011471-18757-3-git-send-email-w.sang@pengutronix.de> (raw)
In-Reply-To: <1356011471-18757-1-git-send-email-w.sang@pengutronix.de>
The datasheet doesn't say anything about writing twice, so this was
probably overlooked.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
drivers/input/misc/adxl34x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
index b18d3e2..6be8687 100644
--- a/drivers/input/misc/adxl34x.c
+++ b/drivers/input/misc/adxl34x.c
@@ -827,7 +827,6 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
if (err)
goto err_remove_attr;
- AC_WRITE(ac, THRESH_TAP, pdata->tap_threshold);
AC_WRITE(ac, OFSX, pdata->x_axis_offset);
ac->hwcal.x = pdata->x_axis_offset;
AC_WRITE(ac, OFSY, pdata->y_axis_offset);
--
1.7.10.4
next prev parent reply other threads:[~2012-12-20 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 13:51 [PATCH 0/4] input adxl34x: give a little love to the driver Wolfram Sang
2012-12-20 13:51 ` [PATCH 1/4] input: adxl34x: consistently use read/write encapsulation Wolfram Sang
2012-12-20 13:51 ` Wolfram Sang [this message]
2012-12-20 13:51 ` [PATCH 3/4] input: adxl34x: make platform_data include self contained Wolfram Sang
2012-12-20 13:51 ` [PATCH 4/4] input: adxl34x: default platform_data should not use defines from driver Wolfram Sang
2012-12-20 14:00 ` [PATCH 0/4] input adxl34x: give a little love to the driver Michael Hennerich
2012-12-24 17:53 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356011471-18757-3-git-send-email-w.sang@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).