From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Zhang Jiejing <jiejing.zhang@freescale.com>,
Hui Wang <jason77.wang@gmail.com>,
linux-input@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Hofemeier, Ulf" <ulf.hofemeier@intel.com>
Subject: eGalax touchscreen regression
Date: Tue, 23 Apr 2013 12:08:08 +0300 [thread overview]
Message-ID: <1366708088.9823.16.camel@sauron.fi.intel.com> (raw)
Hi Dmitry,
in the below commit
commit ae495e844a77344fdaedbb2ad97d925d096e9f0d
Author: Hui Wang <jason77.wang@gmail.com>
Date: Thu Oct 25 00:38:01 2012 -0700
Input: egalax_ts - get gpio from devicetree
The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework
and don't support this API anymore.
The i.MX6q sabrelite platform equips an egalax touchscreen controller,
and this platform already transfered to GENERIC_GPIO framework, to
support this driver, we use a more generic way to get gpio.
Add a return value checking for waking up the controller in the probe
function, this guarantee only a workable device can pass init.
[dmitry.torokhov@gmail.com: Make driver depend on CONFIG_OF as it is
now required.]
Acked-by Zhang Jiejing <jiejing.zhang@freescale.com>
Reviewed-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Hui Wang <jason77.wang@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
the eGalax driver now requires OF. For us this is a regression because
we do not have OF: https://bugs.tizen.org/jira/browse/TIVI-740
--
Best Regards,
Artem Bityutskiy
next reply other threads:[~2013-04-23 9:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 9:08 Artem Bityutskiy [this message]
2013-04-23 11:09 ` [PATCH] input: egalax_ts: remove bogus OF dependency Artem Bityutskiy
2013-04-23 15:37 ` Dmitry Torokhov
2013-04-24 5:58 ` Artem Bityutskiy
2013-04-23 15:40 ` eGalax touchscreen regression Dmitry Torokhov
2013-04-24 6:06 ` Artem Bityutskiy
2013-04-24 9:03 ` Artem Bityutskiy
2013-04-26 14:59 ` Arnd Bergmann
2013-04-26 15:09 ` Artem Bityutskiy
2013-04-26 15:39 ` Dmitry Torokhov
2013-04-26 16:03 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366708088.9823.16.camel@sauron.fi.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jason77.wang@gmail.com \
--cc=jiejing.zhang@freescale.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ulf.hofemeier@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).