From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org,
Ulf Hofemeier <ulf.hofemeier@intel.com>,
Hui Wang <jason77.wang@gmail.com>
Subject: Re: [PATCH] input: egalax_ts: remove bogus OF dependency
Date: Wed, 24 Apr 2013 08:58:27 +0300 [thread overview]
Message-ID: <1366783107.21369.0.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20130423153754.GA4104@core.coreip.homeip.net>
On Tue, 2013-04-23 at 08:37 -0700, Dmitry Torokhov wrote:
> On Tue, Apr 23, 2013 at 02:09:17PM +0300, Artem Bityutskiy wrote:
> > There are platforms using this driver which do not have OF. However, commit
> > ae495e844a77344fdaedbb2ad97d925d096e9f0d added a Kconfig dependency on OF and
> > broke OF-less setups.
> >
> > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> > Cc: stable@vger.kernel.org [v3.7+]
> > ---
> > drivers/input/touchscreen/Kconfig | 2 +-
> > drivers/input/touchscreen/egalax_ts.c | 2 ++
> > 2 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> > index 515cfe7..d53b0d6 100644
> > --- a/drivers/input/touchscreen/Kconfig
> > +++ b/drivers/input/touchscreen/Kconfig
> > @@ -227,7 +227,7 @@ config TOUCHSCREEN_EETI
> >
> > config TOUCHSCREEN_EGALAX
> > tristate "EETI eGalax multi-touch panel support"
> > - depends on I2C && OF
> > + depends on I2C
>
> No, because egalax_wake_up_device() needs OF data and with !CONFIG_OF
> you'll end up using stubs, the wakeup will fail and the touchscreen will
> fail probe.
>
> It wasn't tested, was it?
Not tested. But Ulf (the reporter of the issue) confirms it does not
solve the issue.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-04-24 5:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 9:08 eGalax touchscreen regression Artem Bityutskiy
2013-04-23 11:09 ` [PATCH] input: egalax_ts: remove bogus OF dependency Artem Bityutskiy
2013-04-23 15:37 ` Dmitry Torokhov
2013-04-24 5:58 ` Artem Bityutskiy [this message]
2013-04-23 15:40 ` eGalax touchscreen regression Dmitry Torokhov
2013-04-24 6:06 ` Artem Bityutskiy
2013-04-24 9:03 ` Artem Bityutskiy
2013-04-26 14:59 ` Arnd Bergmann
2013-04-26 15:09 ` Artem Bityutskiy
2013-04-26 15:39 ` Dmitry Torokhov
2013-04-26 16:03 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366783107.21369.0.camel@sauron.fi.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jason77.wang@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ulf.hofemeier@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).