* [PATCH 1/3] Input: altera_ps2 - Remove redundant platform_set_drvdata()
@ 2013-05-03 10:36 Sachin Kamat
2013-05-03 10:36 ` [PATCH 2/3] Input: at32psif " Sachin Kamat
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-05-03 10:36 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Thomas Chou
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Thomas Chou <thomas@wytron.com.tw>
---
drivers/input/serio/altera_ps2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
index 479ce5f..a0a2657 100644
--- a/drivers/input/serio/altera_ps2.c
+++ b/drivers/input/serio/altera_ps2.c
@@ -163,7 +163,6 @@ static int altera_ps2_remove(struct platform_device *pdev)
{
struct ps2if *ps2if = platform_get_drvdata(pdev);
- platform_set_drvdata(pdev, NULL);
serio_unregister_port(ps2if->io);
free_irq(ps2if->irq, ps2if);
iounmap(ps2if->base);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] Input: at32psif - Remove redundant platform_set_drvdata()
2013-05-03 10:36 [PATCH 1/3] Input: altera_ps2 - Remove redundant platform_set_drvdata() Sachin Kamat
@ 2013-05-03 10:36 ` Sachin Kamat
2013-05-03 11:26 ` Hans-Christian Egtvedt
2013-05-03 10:36 ` [PATCH 3/3] Input: q40kbd " Sachin Kamat
2013-05-06 1:38 ` [PATCH 1/3] Input: altera_ps2 " Thomas Chou
2 siblings, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2013-05-03 10:36 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Hans-Christian Egtvedt
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
---
drivers/input/serio/at32psif.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c
index 190ce35..3290b28 100644
--- a/drivers/input/serio/at32psif.c
+++ b/drivers/input/serio/at32psif.c
@@ -314,8 +314,6 @@ static int __exit psif_remove(struct platform_device *pdev)
clk_put(psif->pclk);
kfree(psif);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] Input: at32psif - Remove redundant platform_set_drvdata()
2013-05-03 10:36 ` [PATCH 2/3] Input: at32psif " Sachin Kamat
@ 2013-05-03 11:26 ` Hans-Christian Egtvedt
0 siblings, 0 replies; 5+ messages in thread
From: Hans-Christian Egtvedt @ 2013-05-03 11:26 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-input, dmitry.torokhov
Around Fri 03 May 2013 16:06:39 +0530 or thereabout, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> drivers/input/serio/at32psif.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c
> index 190ce35..3290b28 100644
> --- a/drivers/input/serio/at32psif.c
> +++ b/drivers/input/serio/at32psif.c
> @@ -314,8 +314,6 @@ static int __exit psif_remove(struct platform_device *pdev)
> clk_put(psif->pclk);
> kfree(psif);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
--
mvh
Hans-Christian Egtvedt
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] Input: q40kbd - Remove redundant platform_set_drvdata()
2013-05-03 10:36 [PATCH 1/3] Input: altera_ps2 - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 10:36 ` [PATCH 2/3] Input: at32psif " Sachin Kamat
@ 2013-05-03 10:36 ` Sachin Kamat
2013-05-06 1:38 ` [PATCH 1/3] Input: altera_ps2 " Thomas Chou
2 siblings, 0 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-05-03 10:36 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/input/serio/q40kbd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/serio/q40kbd.c b/drivers/input/serio/q40kbd.c
index 436a343..7a65a1b 100644
--- a/drivers/input/serio/q40kbd.c
+++ b/drivers/input/serio/q40kbd.c
@@ -181,7 +181,6 @@ static int q40kbd_remove(struct platform_device *pdev)
free_irq(Q40_IRQ_KEYBOARD, q40kbd);
kfree(q40kbd);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] Input: altera_ps2 - Remove redundant platform_set_drvdata()
2013-05-03 10:36 [PATCH 1/3] Input: altera_ps2 - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 10:36 ` [PATCH 2/3] Input: at32psif " Sachin Kamat
2013-05-03 10:36 ` [PATCH 3/3] Input: q40kbd " Sachin Kamat
@ 2013-05-06 1:38 ` Thomas Chou
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Chou @ 2013-05-06 1:38 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-input, dmitry.torokhov
Hi Sachin,
On 05/03/2013 06:36 PM, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Thomas Chou <thomas@wytron.com.tw>
> ---
> drivers/input/serio/altera_ps2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
> index 479ce5f..a0a2657 100644
> --- a/drivers/input/serio/altera_ps2.c
> +++ b/drivers/input/serio/altera_ps2.c
> @@ -163,7 +163,6 @@ static int altera_ps2_remove(struct platform_device *pdev)
> {
> struct ps2if *ps2if = platform_get_drvdata(pdev);
>
> - platform_set_drvdata(pdev, NULL);
> serio_unregister_port(ps2if->io);
> free_irq(ps2if->irq, ps2if);
> iounmap(ps2if->base);
>
Acked-by: Thomas Chou <thomas@wytron.com.tw>
Thanks.
- Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-06 1:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-03 10:36 [PATCH 1/3] Input: altera_ps2 - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 10:36 ` [PATCH 2/3] Input: at32psif " Sachin Kamat
2013-05-03 11:26 ` Hans-Christian Egtvedt
2013-05-03 10:36 ` [PATCH 3/3] Input: q40kbd " Sachin Kamat
2013-05-06 1:38 ` [PATCH 1/3] Input: altera_ps2 " Thomas Chou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).