* [PATCH 1/3] Input: q40kbd - Remove redundant platform_set_drvdata()
@ 2013-05-03 10:42 Sachin Kamat
2013-05-03 10:42 ` [PATCH 2/3] Input: amimouse " Sachin Kamat
2013-05-03 10:42 ` [PATCH 3/3] Input: gpio_mouse " Sachin Kamat
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-05-03 10:42 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/input/serio/q40kbd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/serio/q40kbd.c b/drivers/input/serio/q40kbd.c
index 436a343..7a65a1b 100644
--- a/drivers/input/serio/q40kbd.c
+++ b/drivers/input/serio/q40kbd.c
@@ -181,7 +181,6 @@ static int q40kbd_remove(struct platform_device *pdev)
free_irq(Q40_IRQ_KEYBOARD, q40kbd);
kfree(q40kbd);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] Input: amimouse - Remove redundant platform_set_drvdata()
2013-05-03 10:42 [PATCH 1/3] Input: q40kbd - Remove redundant platform_set_drvdata() Sachin Kamat
@ 2013-05-03 10:42 ` Sachin Kamat
2013-05-03 10:42 ` [PATCH 3/3] Input: gpio_mouse " Sachin Kamat
1 sibling, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-05-03 10:42 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/input/mouse/amimouse.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/mouse/amimouse.c b/drivers/input/mouse/amimouse.c
index b55d5af..62ec52b 100644
--- a/drivers/input/mouse/amimouse.c
+++ b/drivers/input/mouse/amimouse.c
@@ -133,7 +133,6 @@ static int __exit amimouse_remove(struct platform_device *pdev)
{
struct input_dev *dev = platform_get_drvdata(pdev);
- platform_set_drvdata(pdev, NULL);
input_unregister_device(dev);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] Input: gpio_mouse - Remove redundant platform_set_drvdata()
2013-05-03 10:42 [PATCH 1/3] Input: q40kbd - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 10:42 ` [PATCH 2/3] Input: amimouse " Sachin Kamat
@ 2013-05-03 10:42 ` Sachin Kamat
2013-05-03 11:27 ` Hans-Christian Egtvedt
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2013-05-03 10:42 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Hans-Christian Egtvedt
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
---
drivers/input/mouse/gpio_mouse.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c
index 532eaca..6b44413 100644
--- a/drivers/input/mouse/gpio_mouse.c
+++ b/drivers/input/mouse/gpio_mouse.c
@@ -138,7 +138,6 @@ static int gpio_mouse_probe(struct platform_device *pdev)
out_free_polldev:
input_free_polled_device(input_poll);
- platform_set_drvdata(pdev, NULL);
out_free_gpios:
while (--i >= 0) {
@@ -165,8 +164,6 @@ static int gpio_mouse_remove(struct platform_device *pdev)
gpio_free(pin);
}
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] Input: gpio_mouse - Remove redundant platform_set_drvdata()
2013-05-03 10:42 ` [PATCH 3/3] Input: gpio_mouse " Sachin Kamat
@ 2013-05-03 11:27 ` Hans-Christian Egtvedt
0 siblings, 0 replies; 4+ messages in thread
From: Hans-Christian Egtvedt @ 2013-05-03 11:27 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-input, dmitry.torokhov
Around Fri 03 May 2013 16:12:22 +0530 or thereabout, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> drivers/input/mouse/gpio_mouse.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c
> index 532eaca..6b44413 100644
> --- a/drivers/input/mouse/gpio_mouse.c
> +++ b/drivers/input/mouse/gpio_mouse.c
> @@ -138,7 +138,6 @@ static int gpio_mouse_probe(struct platform_device *pdev)
>
> out_free_polldev:
> input_free_polled_device(input_poll);
> - platform_set_drvdata(pdev, NULL);
>
> out_free_gpios:
> while (--i >= 0) {
> @@ -165,8 +164,6 @@ static int gpio_mouse_remove(struct platform_device *pdev)
> gpio_free(pin);
> }
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
--
mvh
Hans-Christian Egtvedt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-03 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-03 10:42 [PATCH 1/3] Input: q40kbd - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 10:42 ` [PATCH 2/3] Input: amimouse " Sachin Kamat
2013-05-03 10:42 ` [PATCH 3/3] Input: gpio_mouse " Sachin Kamat
2013-05-03 11:27 ` Hans-Christian Egtvedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).